Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing package versions in Dockerfile #15

Open
sedirmohammed opened this issue Jun 30, 2023 · 1 comment
Open

Missing package versions in Dockerfile #15

sedirmohammed opened this issue Jun 30, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sedirmohammed
Copy link

sedirmohammed commented Jun 30, 2023

I noticed that in the Dockerfile, the version number had not been specified for many packages. This already leads to some ML models not being executable because APIs have changed. For example, with the automatically installed numpy version (for currently 1.24.3), the numpy.float data type no longer exists, making the code in models/vime.py not executable. This bug is easily fixed by simply replacing np.float with float.

Another error occurs, for example, for the ML model STG in models/stg_lib/utils.py. In the collections module used, the collection.Sequence attribute no longer exists, making STG unusable.

In the Dockerfile, the package versions should still be added because more errors will occur sooner or later due to changed interfaces. Also, I have not tested all provided ML models, so further errors can not be excluded.

Many greetings
Sedir Mohammed

@unnir unnir added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 4, 2023
@unnir
Copy link
Collaborator

unnir commented Jul 4, 2023

Thank you for pointing to that, indeed package versions need to be introduced in the docker file. However, due to my workload I'm not able to do that. Therefore, we are welcome open-source contributors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants