Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react): move theme types into system #532

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

resir014
Copy link
Contributor

Reference: #518 (task 1)

Description

Move types.ts file in theme folder into system folder, and provide these types as exportable.

@vercel
Copy link

vercel bot commented Oct 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kata-ai/aksara-ui/4gT8v7k4DwGQSBMUYEdaDHHvdqZX
✅ Preview: https://aksara-ui-git-refactor-reactmove-types-into-system-kata-ai.vercel.app

@resir014 resir014 requested a review from zanuarmirza October 27, 2021 13:16
@resir014 resir014 marked this pull request as ready for review October 27, 2021 13:17
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #532 (e683a37) into master (f2f4a0c) will not change coverage.
The diff coverage is n/a.

❗ Current head e683a37 differs from pull request most recent head 804e34b. Consider uploading reports for the commit 804e34b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #532   +/-   ##
=======================================
  Coverage   60.09%   60.09%           
=======================================
  Files         166      166           
  Lines        1526     1526           
  Branches      437      437           
=======================================
  Hits          917      917           
  Misses        609      609           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d0611...804e34b. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@resir014 resir014 merged commit 231e300 into master Oct 28, 2021
@resir014 resir014 deleted the refactor/react/move-types-into-system branch October 28, 2021 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant