Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] Split src/system into its own package #518

Open
1 of 3 tasks
Tracked by #505
resir014 opened this issue Oct 22, 2021 · 0 comments
Open
1 of 3 tasks
Tracked by #505

[react] Split src/system into its own package #518

resir014 opened this issue Oct 22, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@resir014
Copy link
Contributor

resir014 commented Oct 22, 2021

Description

To allow for (hopefully) faster compile times, we should split off the system folder in @aksara-ui/react into its own package (@aksara-ui/system).

Implementation Model

This package will act as a wrapper for styled-system, adding helper APIs that have been present in aksara-ui, like the componentStyles API. Most of the styled-system general APIs (particularly the one that we use) will also be exported through this package.

Tasks

  • Move types.ts file in theme folder into system folder, and provide these types as exportable.
  • Create new package in monorepo called @aksara-ui/system, and move all files in the system folder there.
  • Move styled-system + other dependencies as necessary into the new package.
@resir014 resir014 added the enhancement New feature or request label Oct 22, 2021
@resir014 resir014 changed the title Split aksara-ui/system into its own package [@aksara-ui/react] Split src/system into its own package Oct 22, 2021
@resir014 resir014 changed the title [@aksara-ui/react] Split src/system into its own package [react] Split src/system into its own package Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants