Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes on committers that are not GitHub users #38

Open
eush77 opened this issue Nov 4, 2015 · 1 comment
Open

Crashes on committers that are not GitHub users #38

eush77 opened this issue Nov 4, 2015 · 1 comment

Comments

@eush77
Copy link

eush77 commented Nov 4, 2015

Tried it on a big repo and the app crashed. (Sorry about that!)
screenshot

@eush77
Copy link
Author

eush77 commented Nov 4, 2015

It doesn't matter whether repository is big or not (GitHub API pages results anyway).

In this case committer is not a GitHub user and has no login or avatar.

/tmp/tmpdir/G95AZH/commit4/githubrequest.js:45
        username: commit.committer.login,
                                  ^

TypeError: Cannot read property 'login' of null
    at addCommitToHistoryObject (/tmp/tmpdir/G95AZH/commit4/githubrequest.js:45:35)
    at Array.forEach (native)
    at /tmp/tmpdir/G95AZH/commit4/githubrequest.js:35:36
    at IncomingMessage.<anonymous> (/tmp/tmpdir/G95AZH/commit4/githubrequest.js:87:7)
    at emitNone (events.js:72:20)
    at IncomingMessage.emit (events.js:166:7)
    at endReadableNT (_stream_readable.js:893:12)
    at doNTCallback2 (node.js:429:9)
    at process._tickCallback (node.js:343:17)

@eush77 eush77 changed the title Crashes on big repos Crashes on committers that are not GitHub users Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant