Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "uptime" parameter to a GetInfo request #2012

Open
Aleoami opened this issue Apr 7, 2022 · 1 comment · May be fixed by #2095
Open

Add the "uptime" parameter to a GetInfo request #2012

Aleoami opened this issue Apr 7, 2022 · 1 comment · May be fixed by #2095

Comments

@Aleoami
Copy link
Contributor

Aleoami commented Apr 7, 2022

Or even create a separate GetStats request, answer to which could be populated with all kinds of info: like a number of p2p and RPC clients, a number of RPC requests responded total, TX requests and block template requests specifically, TXes included into submitted blocks, avg and max RPC request per second, blocks accepted via relay and via submitBlock, and whatever else could be interesting for the node runner.

@D-Stacks
Copy link
Contributor

I will do this i actually think these would be interessting stats to have. I will do uptime specifically in GetInfo / maybe also number of rpc clients, and max clients, I think everything pertaining to the question of "do I want to connect to this node" shoould go into getInfo, but the rest in a new GetStats.

It might require the implementation of a small stat tracking package imo. I see this as useful for exmaple in future gui aplications, or kdx, that wrap the node with gui, and as a notification message for a livefeed of how the node is performing. It can also expose what addresses are mining to the node. Which currently is hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants