Update X11 patches

[CorbinWunderlich]

Is your feature request related to a problem? Please describe.
I am trying to build a package for NixOS and all of the recent versions of NixOS package newer versions than version 20. Please create patches for version 21.

[CorbinWunderlich]

Just another thing @clbr , why do the cmake lists in tests/ still reference tigervnc vncviewer paths? That should also be fixed

[clbr]

We have this on our jammy build branch, but IIRC there was some problem with it. For the tests, they aren't used, as we don't have a native viewer.

[CorbinWunderlich]

We have this on our jammy build branch, but IIRC there was some problem with it. For the tests, they aren't used, as we don't have a native viewer.

Which branch doesn't have the references to those viewer files?

[CorbinWunderlich]

I also think the tests are used, as the normal CMake list includes the test subdir at line 248. You could get rid of that.

[clbr]

The Jammy branch with the Xorg patch seems to be private. I'll see what I can do about refreshing it and moving it forward.

For the tests, we skip those in our build commands, see build.sh. No branch has that commented out in the Cmake file.

[CorbinWunderlich]

Please make it public. it is gpl after all.

[mmcclaskey]

KasmVNC is maintained in our private Gitlab and mirrored to Github public. Only the default branch and branches that map to publicly released versions of KasmVNC are mirrored to github. We are not required to publish source code that is not part of a public released. Reference https://www.gnu.org/licenses/old-licenses/gpl-2.0-faq.en.html#TOCGPLRequireSourcePostedPublic

We do not create builds of KasmVNC from branches that are not made public. So the Ubuntu Jammy build of KasmVNC that is on the releases page, is built from the release/x.x.x branch that is public. We have in the past experimented with different Xorg patches and Xorg versions, and there might be private branches that @clbr is referencing. But those branches had issues and never got merged in and no builds based on that code were ever published.

Off hand, I do not recall the issues we ran into and why we backed down the Xorg version. But I do recall we ran into issues when trying to get to later releases. It is something we would have to re-engage on as it has been quite some time.

[CorbinWunderlich]

TigerVNC has updated patches that could be used as a reference as far as I know, but I doubt they are similar to KasmVNC's patches anymore.

[mmcclaskey]

We should be able to reference the patches used by TigerVNC, we will look into it.