Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-Shift-F12 results in command 'workbench.action.maximizeEditor' not found #341

Open
htbkoo opened this issue Apr 6, 2024 · 4 comments

Comments

@htbkoo
Copy link

htbkoo commented Apr 6, 2024

First of all, thanks a lot for creating this extension which is extremely helpful for users who are used to Keybindings from IntelliJ IDEA! 👍

Recently, I had bumped into this problem with a very frequently used shortcut - the Ctrl-Shift-F12 to maximize editor (and hide all the panels) - instead of maximizing the editor, I just get this error message:

command 'workbench.action.maximizeEditor' not found

Are there any configuration changes I need to (I have not used VS Code in a while, so probably something has changed and ruined the whole setup after all the auto-update, which I should have just turned off completely 🤦 )

Let me know if you need more information. 💪

Thank you!

@htbkoo
Copy link
Author

htbkoo commented Apr 6, 2024

I had tried to search for similar issues with keywords like maximizeEditor / F12 / expand (reference: microsoft/vscode#197227) but did not find anything directly related.

Please feel free to close this if this is actually a duplicate 🙇

@kasecato kasecato self-assigned this Apr 7, 2024
@kasecato kasecato added the bug label Apr 7, 2024
@kasecato
Copy link
Owner

kasecato commented Apr 7, 2024

Let me remove support for this key binding in the next release.
To support IntelliJ behavior, we need to keep the previous sidebar and bottom panel state.
In addition, focus control is also necessary because the focus moves to the terminal on its own when the bottom panel is the terminal.

            {
                "key": "ctrl+shift+f12",
                "mac": "cmd+shift+f12",
                "command": "runCommands",
                "args": {
                    "commands": [
                        "workbench.action.toggleSidebarVisibility",
                        "workbench.action.togglePanel"
                    ]
                },
                "when": "(sideBarVisible && panelVisible) || (!sideBarVisible && !panelVisible)",
                "intellij": "Toggle maximizing editor"
            },

@htbkoo
Copy link
Author

htbkoo commented Apr 8, 2024

Thanks a lot for your prompt reply and sharing the information 🙇

kasecato added a commit that referenced this issue Apr 20, 2024
kasecato added a commit that referenced this issue Apr 20, 2024
Removed #341 that Ctrl-Shift-F12 results in command 'workbench.action…
@grgar
Copy link
Contributor

grgar commented Apr 28, 2024

There's a few extensions that try to achieve this, but don't do it quite right, so I wrote my own: Sidebars. I didn't think it quite fit here since it requires maintaining some state and currently does so using undocumented/private command calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants