Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe a mistake in lstm_generator.py #41

Open
liu09114 opened this issue Nov 19, 2015 · 2 comments
Open

Maybe a mistake in lstm_generator.py #41

liu09114 opened this issue Nov 19, 2015 · 2 comments

Comments

@liu09114
Copy link

In the lstm_generator.py, line 71 Hin[t,1:1+d] = X[t] and 72 Hin[t,1+d:] = prev should be exchanged.
Because the hidden size is d, which is the dimension of the prev.
But i don't why it doesn't raise an error, anyone can explain this?

@liu09114
Copy link
Author

I know why it doesn't raise an error. The default parameter of the image encoding size (also the input size) id equal to the hidden size.
But the mistake should be correct.

@karpathy
Copy link
Owner

oops, i think you're probably right. If you try to meddle with the sizes it would error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants