Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model self-attention hardcoded to 4 heads #71

Closed
SpeedCoder5 opened this issue Apr 25, 2022 · 1 comment
Closed

model self-attention hardcoded to 4 heads #71

SpeedCoder5 opened this issue Apr 25, 2022 · 1 comment

Comments

@SpeedCoder5
Copy link

The self attention block is hard-coded to 4 heads. Suggest using n_heads from config instead.
@SpeedCoder5 SpeedCoder5 reopened this Apr 25, 2022
SpeedCoder5 added a commit to SpeedCoder5/minGPT that referenced this issue Apr 25, 2022
@SpeedCoder5
karpathy#71 use config n_head instead of hardcoded 4 heads
0ac226d
@SpeedCoder5
Copy link
Author

submitted PR #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SpeedCoder5