change retention for redpanda (#474)

* change retention for redpanda * fix comment --------- Signed-off-by: Maciej Mensfeld <[email protected]>
karafka · Nov 22, 2024 · c3c24d4 · c3c24d4
1 parent 9a09a68
commit c3c24d4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 - **[Breaking]** Drop Ruby `3.0` support according to the EOL schedule.
 - [Enhancement] Extract producers tracking `sync_threshold` into an internal config.
 - [Enhancement] Support complex Pro license loading strategies (Pro).
+- [Enhancement] Change default `retention.ms` for the metrics topic to support Redpanda Cloud defaults (#450).
 - [Enhancement] Include subscription group id in the consumers error tracking metadata.
 - [Enhancement] Collect metadata details of low level client errors when error tracking.
 - [Enhancement] Collect metadata details of low level listener errors when error tracking.

diff --git a/lib/karafka/web/management/actions/create_topics.rb b/lib/karafka/web/management/actions/create_topics.rb
@@ -81,7 +81,7 @@ def call(replication_factor)
                 replication_factor,
                 {
                   'cleanup.policy': 'compact',
-                  'retention.ms': 60 * 60 * 1_000, # 1h
+                  'retention.ms': 24 * 60 * 60 * 1_000, # 1 day
                   'segment.ms': 24 * 60 * 60 * 1_000, # 1 day
                   'segment.bytes': 104_857_600 # 100MB
                 }