From 1fea109eccbf5dbbe78f4b6a6fb5e3fcd0398d50 Mon Sep 17 00:00:00 2001
From: Tiago Costa <tiago.costa@elastic.co>
Date: Thu, 21 Nov 2024 20:06:15 +0000
Subject: [PATCH] fix(NA): eslint

---
 .../all/alerts_response_actions_form.cy.ts    | 434 +++++++++---------
 1 file changed, 219 insertions(+), 215 deletions(-)

diff --git a/x-pack/plugins/osquery/cypress/e2e/all/alerts_response_actions_form.cy.ts b/x-pack/plugins/osquery/cypress/e2e/all/alerts_response_actions_form.cy.ts
index a90e3cd65ebe4..4d8a83d8d6b5f 100644
--- a/x-pack/plugins/osquery/cypress/e2e/all/alerts_response_actions_form.cy.ts
+++ b/x-pack/plugins/osquery/cypress/e2e/all/alerts_response_actions_form.cy.ts
@@ -25,227 +25,231 @@ import { clickRuleName, inputQuery, typeInECSFieldInput } from '../../tasks/live
 import { closeDateTabIfVisible, closeToastIfVisible } from '../../tasks/integrations';
 
 // FLAKY: https://github.com/elastic/kibana/issues/169785
-describe.skip('Alert Event Details - Response Actions Form', { tags: ['@ess', '@serverless'] }, () => {
-  let multiQueryPackId: string;
-  let multiQueryPackName: string;
-  let ruleId: string;
-  let ruleName: string;
-  let packId: string;
-  let packName: string;
-  const packData = packFixture();
-  const multiQueryPackData = multiQueryPackFixture();
-  before(() => {
-    initializeDataViews();
-  });
-  beforeEach(() => {
-    loadPack(packData).then((data) => {
-      packId = data.saved_object_id;
-      packName = data.name;
-    });
-    loadPack(multiQueryPackData).then((data) => {
-      multiQueryPackId = data.saved_object_id;
-      multiQueryPackName = data.name;
-    });
-    loadRule().then((data) => {
-      ruleId = data.id;
-      ruleName = data.name;
-    });
-  });
-  afterEach(() => {
-    cleanupPack(packId);
-    cleanupPack(multiQueryPackId);
-    cleanupRule(ruleId);
-  });
-
-  it('adds response actions with osquery with proper validation and form values', () => {
-    cy.visit('/app/security/rules');
-    clickRuleName(ruleName);
-    cy.getBySel('globalLoadingIndicator').should('not.exist');
-    cy.getBySel('editRuleSettingsLink').click();
-    cy.getBySel('globalLoadingIndicator').should('not.exist');
-    closeDateTabIfVisible();
-    cy.getBySel('edit-rule-actions-tab').click();
-    cy.getBySel('globalLoadingIndicator').should('not.exist');
-    cy.contains('Response actions are run on each rule execution.');
-    cy.getBySel(OSQUERY_RESPONSE_ACTION_ADD_BUTTON).click();
-
-    cy.getBySel(RESPONSE_ACTIONS_ERRORS).within(() => {
-      cy.contains('Query is a required field');
-      cy.contains('The timeout value must be 60 seconds or higher.').should('not.exist');
-    });
-
-    // check if changing error state of one input doesn't clear other errors - START
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
-      cy.contains('Advanced').click();
-      cy.getBySel('timeout-input').clear();
-      cy.contains('The timeout value must be 60 seconds or higher.');
-    });
-
-    cy.getBySel(RESPONSE_ACTIONS_ERRORS).within(() => {
-      cy.contains('Query is a required field');
-      cy.contains('The timeout value must be 60 seconds or higher.');
-    });
-
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
-      cy.getBySel('timeout-input').type('6');
-      cy.contains('The timeout value must be 60 seconds or higher.');
-    });
-    cy.getBySel(RESPONSE_ACTIONS_ERRORS).within(() => {
-      cy.contains('Query is a required field');
-      cy.contains('The timeout value must be 60 seconds or higher.');
-    });
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
-      cy.getBySel('timeout-input').type('6');
-      cy.contains('The timeout value must be 60 seconds or higher.').should('not.exist');
-    });
-    cy.getBySel(RESPONSE_ACTIONS_ERRORS).within(() => {
-      cy.contains('Query is a required field');
-    });
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
-      cy.getBySel('timeout-input').type('6');
-    });
-    cy.getBySel(RESPONSE_ACTIONS_ERRORS).within(() => {
-      cy.contains('Query is a required field');
-      cy.contains('The timeout value must be 60 seconds or higher.').should('not.exist');
-    });
-    // check if changing error state of one input doesn't clear other errors - END
+describe.skip(
+  'Alert Event Details - Response Actions Form',
+  { tags: ['@ess', '@serverless'] },
+  () => {
+    let multiQueryPackId: string;
+    let multiQueryPackName: string;
+    let ruleId: string;
+    let ruleName: string;
+    let packId: string;
+    let packName: string;
+    const packData = packFixture();
+    const multiQueryPackData = multiQueryPackFixture();
+    before(() => {
+      initializeDataViews();
+    });
+    beforeEach(() => {
+      loadPack(packData).then((data) => {
+        packId = data.saved_object_id;
+        packName = data.name;
+      });
+      loadPack(multiQueryPackData).then((data) => {
+        multiQueryPackId = data.saved_object_id;
+        multiQueryPackName = data.name;
+      });
+      loadRule().then((data) => {
+        ruleId = data.id;
+        ruleName = data.name;
+      });
+    });
+    afterEach(() => {
+      cleanupPack(packId);
+      cleanupPack(multiQueryPackId);
+      cleanupRule(ruleId);
+    });
+
+    it('adds response actions with osquery with proper validation and form values', () => {
+      cy.visit('/app/security/rules');
+      clickRuleName(ruleName);
+      cy.getBySel('globalLoadingIndicator').should('not.exist');
+      cy.getBySel('editRuleSettingsLink').click();
+      cy.getBySel('globalLoadingIndicator').should('not.exist');
+      closeDateTabIfVisible();
+      cy.getBySel('edit-rule-actions-tab').click();
+      cy.getBySel('globalLoadingIndicator').should('not.exist');
+      cy.contains('Response actions are run on each rule execution.');
+      cy.getBySel(OSQUERY_RESPONSE_ACTION_ADD_BUTTON).click();
+
+      cy.getBySel(RESPONSE_ACTIONS_ERRORS).within(() => {
+        cy.contains('Query is a required field');
+        cy.contains('The timeout value must be 60 seconds or higher.').should('not.exist');
+      });
 
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
-      cy.contains('Query is a required field');
-      inputQuery('select * from uptime1');
-    });
-    cy.getBySel(OSQUERY_RESPONSE_ACTION_ADD_BUTTON).click();
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_1).within(() => {
-      cy.contains('Run a set of queries in a pack').click();
-    });
-    cy.getBySel(RESPONSE_ACTIONS_ERRORS)
-      .within(() => {
-        cy.contains('Pack is a required field');
-      })
-      .should('exist');
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_1).within(() => {
-      cy.contains('Pack is a required field');
-      cy.getBySel('comboBoxInput').click();
-      cy.getBySel('comboBoxInput').type(`${packName}`);
-      cy.contains(`doesn't match any options`).should('not.exist');
-      cy.getBySel('comboBoxInput').type('{downArrow}{enter}');
-    });
+      // check if changing error state of one input doesn't clear other errors - START
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
+        cy.contains('Advanced').click();
+        cy.getBySel('timeout-input').clear();
+        cy.contains('The timeout value must be 60 seconds or higher.');
+      });
 
-    cy.getBySel(OSQUERY_RESPONSE_ACTION_ADD_BUTTON).click();
+      cy.getBySel(RESPONSE_ACTIONS_ERRORS).within(() => {
+        cy.contains('Query is a required field');
+        cy.contains('The timeout value must be 60 seconds or higher.');
+      });
+
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
+        cy.getBySel('timeout-input').type('6');
+        cy.contains('The timeout value must be 60 seconds or higher.');
+      });
+      cy.getBySel(RESPONSE_ACTIONS_ERRORS).within(() => {
+        cy.contains('Query is a required field');
+        cy.contains('The timeout value must be 60 seconds or higher.');
+      });
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
+        cy.getBySel('timeout-input').type('6');
+        cy.contains('The timeout value must be 60 seconds or higher.').should('not.exist');
+      });
+      cy.getBySel(RESPONSE_ACTIONS_ERRORS).within(() => {
+        cy.contains('Query is a required field');
+      });
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
+        cy.getBySel('timeout-input').type('6');
+      });
+      cy.getBySel(RESPONSE_ACTIONS_ERRORS).within(() => {
+        cy.contains('Query is a required field');
+        cy.contains('The timeout value must be 60 seconds or higher.').should('not.exist');
+      });
+      // check if changing error state of one input doesn't clear other errors - END
 
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_2)
-      .within(() => {
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
         cy.contains('Query is a required field');
-        inputQuery('select * from uptime');
-        cy.contains('Query is a required field').should('not.exist');
-        cy.contains('Advanced').click();
-        typeInECSFieldInput('label{downArrow}{enter}');
-        cy.getBySel('osqueryColumnValueSelect').type('days{downArrow}{enter}');
-      })
-      .clickOutside();
-
-    cy.getBySel('ruleEditSubmitButton').click();
-    cy.contains(`${ruleName} was saved`).should('exist');
-    closeToastIfVisible();
-
-    cy.getBySel('globalLoadingIndicator').should('not.exist');
-    cy.getBySel('editRuleSettingsLink').click();
-    cy.getBySel('globalLoadingIndicator').should('not.exist');
-    cy.getBySel('edit-rule-actions-tab').click();
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
-      cy.contains('select * from uptime1');
-    });
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_2).within(() => {
-      cy.contains('select * from uptime');
-      cy.contains('Custom key/value pairs. e.g. {"application":"foo-bar","env":"production"}');
-      cy.contains('Days of uptime');
-    });
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_1).within(() => {
-      cy.getBySel('comboBoxSearchInput').should('have.value', packName);
-      cy.getBySel('comboBoxInput').type('{selectall}{backspace}{enter}');
-    });
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
-      cy.contains('select * from uptime1');
-      cy.getBySel('remove-response-action').click();
-    });
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_0)
-      .within(() => {
-        cy.getBySel('comboBoxSearchInput').click();
-        cy.contains('Search for a pack to run');
+        inputQuery('select * from uptime1');
+      });
+      cy.getBySel(OSQUERY_RESPONSE_ACTION_ADD_BUTTON).click();
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_1).within(() => {
+        cy.contains('Run a set of queries in a pack').click();
+      });
+      cy.getBySel(RESPONSE_ACTIONS_ERRORS)
+        .within(() => {
+          cy.contains('Pack is a required field');
+        })
+        .should('exist');
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_1).within(() => {
         cy.contains('Pack is a required field');
-        cy.getBySel('comboBoxInput').type(`${packName}{downArrow}{enter}`);
-        cy.contains(packName);
-      })
-      .clickOutside();
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_1).within(() => {
-      cy.contains('select * from uptime');
-      cy.contains('Custom key/value pairs. e.g. {"application":"foo-bar","env":"production"}');
-      cy.contains('Days of uptime');
-    });
-
-    cy.intercept('PUT', '/api/detection_engine/rules').as('saveRuleSingleQuery');
-
-    cy.getBySel('ruleEditSubmitButton').click();
-    cy.wait('@saveRuleSingleQuery', { timeout: 15000 }).should(({ request }) => {
-      const oneQuery = [
-        {
-          interval: 3600,
-          query: 'select * from uptime;',
-          id: Object.keys(packData.queries)[0],
-        },
-      ];
-      expect(request.body.response_actions[0].params.queries).to.deep.equal(oneQuery);
-    });
-
-    cy.contains(`${ruleName} was saved`).should('exist');
-    closeToastIfVisible();
-
-    cy.getBySel('globalLoadingIndicator').should('not.exist');
-    cy.getBySel('editRuleSettingsLink').click();
-    cy.getBySel('globalLoadingIndicator').should('not.exist');
-
-    cy.getBySel('edit-rule-actions-tab').click();
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_0)
-      .within(() => {
+        cy.getBySel('comboBoxInput').click();
+        cy.getBySel('comboBoxInput').type(`${packName}`);
+        cy.contains(`doesn't match any options`).should('not.exist');
+        cy.getBySel('comboBoxInput').type('{downArrow}{enter}');
+      });
+
+      cy.getBySel(OSQUERY_RESPONSE_ACTION_ADD_BUTTON).click();
+
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_2)
+        .within(() => {
+          cy.contains('Query is a required field');
+          inputQuery('select * from uptime');
+          cy.contains('Query is a required field').should('not.exist');
+          cy.contains('Advanced').click();
+          typeInECSFieldInput('label{downArrow}{enter}');
+          cy.getBySel('osqueryColumnValueSelect').type('days{downArrow}{enter}');
+        })
+        .clickOutside();
+
+      cy.getBySel('ruleEditSubmitButton').click();
+      cy.contains(`${ruleName} was saved`).should('exist');
+      closeToastIfVisible();
+
+      cy.getBySel('globalLoadingIndicator').should('not.exist');
+      cy.getBySel('editRuleSettingsLink').click();
+      cy.getBySel('globalLoadingIndicator').should('not.exist');
+      cy.getBySel('edit-rule-actions-tab').click();
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
+        cy.contains('select * from uptime1');
+      });
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_2).within(() => {
+        cy.contains('select * from uptime');
+        cy.contains('Custom key/value pairs. e.g. {"application":"foo-bar","env":"production"}');
+        cy.contains('Days of uptime');
+      });
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_1).within(() => {
         cy.getBySel('comboBoxSearchInput').should('have.value', packName);
-        cy.getBySel('comboBoxInput').type(
-          `{selectall}{backspace}${multiQueryPackName}{downArrow}{enter}`
-        );
-        cy.contains('SELECT * FROM memory_info;');
-        cy.contains('SELECT * FROM system_info;');
-      })
-      .clickOutside();
-
-    cy.getBySel(RESPONSE_ACTIONS_ITEM_1)
-      .within(() => {
+        cy.getBySel('comboBoxInput').type('{selectall}{backspace}{enter}');
+      });
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
+        cy.contains('select * from uptime1');
+        cy.getBySel('remove-response-action').click();
+      });
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_0)
+        .within(() => {
+          cy.getBySel('comboBoxSearchInput').click();
+          cy.contains('Search for a pack to run');
+          cy.contains('Pack is a required field');
+          cy.getBySel('comboBoxInput').type(`${packName}{downArrow}{enter}`);
+          cy.contains(packName);
+        })
+        .clickOutside();
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_1).within(() => {
         cy.contains('select * from uptime');
         cy.contains('Custom key/value pairs. e.g. {"application":"foo-bar","env":"production"}');
         cy.contains('Days of uptime');
-      })
-      .clickOutside();
-    cy.intercept('PUT', '/api/detection_engine/rules').as('saveRuleMultiQuery');
-
-    cy.contains('Save changes').click();
-    cy.wait('@saveRuleMultiQuery', { timeout: 15000 }).should(({ request }) => {
-      const threeQueries = [
-        {
-          interval: 3600,
-          query: 'SELECT * FROM memory_info;',
-          platform: 'linux',
-          id: Object.keys(multiQueryPackData.queries)[0],
-        },
-        {
-          interval: 3600,
-          query: 'SELECT * FROM system_info;',
-          id: Object.keys(multiQueryPackData.queries)[1],
-        },
-        {
-          interval: 10,
-          query: 'select opera_extensions.* from users join opera_extensions using (uid);',
-          id: Object.keys(multiQueryPackData.queries)[2],
-        },
-      ];
-      expect(request.body.response_actions[0].params.queries).to.deep.equal(threeQueries);
-    });
-  });
-});
+      });
+
+      cy.intercept('PUT', '/api/detection_engine/rules').as('saveRuleSingleQuery');
+
+      cy.getBySel('ruleEditSubmitButton').click();
+      cy.wait('@saveRuleSingleQuery', { timeout: 15000 }).should(({ request }) => {
+        const oneQuery = [
+          {
+            interval: 3600,
+            query: 'select * from uptime;',
+            id: Object.keys(packData.queries)[0],
+          },
+        ];
+        expect(request.body.response_actions[0].params.queries).to.deep.equal(oneQuery);
+      });
+
+      cy.contains(`${ruleName} was saved`).should('exist');
+      closeToastIfVisible();
+
+      cy.getBySel('globalLoadingIndicator').should('not.exist');
+      cy.getBySel('editRuleSettingsLink').click();
+      cy.getBySel('globalLoadingIndicator').should('not.exist');
+
+      cy.getBySel('edit-rule-actions-tab').click();
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_0)
+        .within(() => {
+          cy.getBySel('comboBoxSearchInput').should('have.value', packName);
+          cy.getBySel('comboBoxInput').type(
+            `{selectall}{backspace}${multiQueryPackName}{downArrow}{enter}`
+          );
+          cy.contains('SELECT * FROM memory_info;');
+          cy.contains('SELECT * FROM system_info;');
+        })
+        .clickOutside();
+
+      cy.getBySel(RESPONSE_ACTIONS_ITEM_1)
+        .within(() => {
+          cy.contains('select * from uptime');
+          cy.contains('Custom key/value pairs. e.g. {"application":"foo-bar","env":"production"}');
+          cy.contains('Days of uptime');
+        })
+        .clickOutside();
+      cy.intercept('PUT', '/api/detection_engine/rules').as('saveRuleMultiQuery');
+
+      cy.contains('Save changes').click();
+      cy.wait('@saveRuleMultiQuery', { timeout: 15000 }).should(({ request }) => {
+        const threeQueries = [
+          {
+            interval: 3600,
+            query: 'SELECT * FROM memory_info;',
+            platform: 'linux',
+            id: Object.keys(multiQueryPackData.queries)[0],
+          },
+          {
+            interval: 3600,
+            query: 'SELECT * FROM system_info;',
+            id: Object.keys(multiQueryPackData.queries)[1],
+          },
+          {
+            interval: 10,
+            query: 'select opera_extensions.* from users join opera_extensions using (uid);',
+            id: Object.keys(multiQueryPackData.queries)[2],
+          },
+        ];
+        expect(request.body.response_actions[0].params.queries).to.deep.equal(threeQueries);
+      });
+    });
+  }
+);