Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify custom extension in inventory #276

Closed
uberspot opened this issue Apr 25, 2019 · 8 comments
Closed

Add ability to specify custom extension in inventory #276

uberspot opened this issue Apr 25, 2019 · 8 comments
Assignees
Labels
easy difficulty: easy enhancement enhancement to an existing feature

Comments

@uberspot
Copy link
Contributor

Following roboll/helmfile#565
It makes sense to allow custom extensions for inventory files (yml or yaml) to make kapitan more flexible. :)

@uberspot uberspot added easy difficulty: easy enhancement enhancement to an existing feature labels Apr 25, 2019
@adrianchifor
Copy link
Member

Inventory files are interpreted by reclass. Relevant TODO https://github.com/salt-formulas/reclass/blob/develop/doc/source/todo.rst#configurable-file-extension.

We could make an MR to update reclass/storage/yaml_fs/__init__.py and reclass/storage/yaml_fs/directory.py as it hardcodes FILE_EXTENSION = '.yml'.

@pranavgupta1234
Copy link
Contributor

pranavgupta1234 commented Apr 28, 2019

I would like to take up this issue. Should I open an corresponding issue on https://github.com/salt-formulas/reclass ? Is there any plan to update reclass to v1.6.0 ?

@uberspot
Copy link
Contributor Author

Go for it. We could also make a PR in kapitan to update reclass if it's not breaking.

@pranavgupta1234
Copy link
Contributor

Ref : salt-formulas/reclass#85

@pranavgupta1234
Copy link
Contributor

@uberspot salt-formulas/reclass#85 is merged now.

@uberspot
Copy link
Contributor Author

Wonderful! :) They haven't pushed a new release though so I doubt we can upgrade reclass at the moment unless we maintain our own mirror. :/
Also this regression still remains salt-formulas/reclass#84

@adrianchifor
Copy link
Member

For visibility, we are waiting for salt-formulas/reclass#87 to be merged and for reclass to make a new release.

@uberspot
Copy link
Contributor Author

This has now been added in kapitan 0.27.3 after forking and updating our usage of reclass. :)
Closing as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy difficulty: easy enhancement enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants