Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted images continue to show in QuickViewer #155

Open
ErikLacharite opened this issue Jul 21, 2020 · 3 comments
Open

Deleted images continue to show in QuickViewer #155

ErikLacharite opened this issue Jul 21, 2020 · 3 comments
Labels

Comments

@ErikLacharite
Copy link

My expected behaviour is that the deleted image would be removed from the list view, and the slide-show view (and the slide count to be decremented by -1).

@kanryu
Copy link
Owner

kanryu commented Jul 21, 2020

Basically, QuickViewer doesn't anticipate events where images are added to or deleted from a folder after the folder's images are displayed. The only time changes are reflected is when QuickViwer itself deletes or moves an image to the trash.

Some people may think this behavior is a bug. However, to improve this behavior, we need to monitor file changes in folders. This may not be feasible due to the incompatibility of different OSes.

@kanryu kanryu added the bug label Jul 21, 2020
@ErikLacharite
Copy link
Author

I am seeing this issue when deleting images from the QuickViewer UI (Windows 10).

But related to you comment, if you are thinking of adding a file/folder monitor to the OS, see: https://doc.qt.io/qt-5/qfilesystemwatcher.html#directoryChanged

@kanryu
Copy link
Owner

kanryu commented Jul 28, 2020

If QuickViewer deletes the image itself or moves it to the trash, the problem you pointed out will not occur. As long as the program is working properly.

To see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants