Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions are incorrect currently #6

Closed
yaleman opened this issue Oct 18, 2024 · 3 comments · Fixed by #10 · May be fixed by #5
Closed

Instructions are incorrect currently #6

yaleman opened this issue Oct 18, 2024 · 3 comments · Fixed by #10 · May be fixed by #5

Comments

@yaleman
Copy link
Member

yaleman commented Oct 18, 2024

  • key file is .asc, needs to be kanidm_ppa.asc
  • apt list filter's wrong
  • probably should call out that that nightly's are there and comment them out by default so monkeys like me don't automatically install them 🤦🏻

apt filter things

sudo curl -s --compressed "https://kanidm.github.io/kanidm_ppa/kanidm_ppa.list" \
    | grep $( ( . /etc/os-release && echo $ID) ) \
    | sudo tee /etc/apt/sources.list.d/kanidm_ppa.list

ID probably needs to be VERSION_CODENAME?

sudo curl -s --compressed "https://kanidm.github.io/kanidm_ppa/kanidm_ppa.list" \
    | grep $( ( . /etc/os-release && echo $VERSION_CODENAME) ) \
    | sudo tee /etc/apt/sources.list.d/kanidm_ppa.list

debian:

# cat /etc/os-release
VERSION_CODENAME=bookworm
ID=debian

ubuntu:

# cat /etc/os-release
VERSION_CODENAME=noble
ID=ubuntu
@jinnatar
Copy link
Collaborator

The latest version of the instructions filters on $VERSION_CODENAME, but needs a rebuild to show up in the repo. In theory just re-triggering the previous run will fix this now that the upstream PR was merged.

@jinnatar
Copy link
Collaborator

jinnatar commented Oct 19, 2024

I've re-triggered just the publish stage, that should update to the latest README.md: https://github.com/kanidm/kanidm_ppa_automation/actions/runs/11379035668

Confirmed, latest instructions now at: https://kanidm.github.io/kanidm_ppa/

Does that solve that portion of your issue?

The second portion, i.e. the kanidm_ppa.list having .gpg is fixed in the aptly action, but requires a version bump. I've got that in the works in #5

jinnatar added a commit to jinnatar/kanidm_ppa_automation that referenced this issue Oct 19, 2024
Includes bugfix for kanidm_ppa.list having the wrong key type, Fixes kanidm#6
@yaleman
Copy link
Member Author

yaleman commented Oct 19, 2024

No worries at all, just had one of those "I'll quickly test thi.... oh no" mornings 😄 thanks for being super responsive as always!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants