feat(ci): Add test step to CI #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@mcanueste is attempting to deploy a commit to the kamp-us Team on Vercel. A member of the Team first needs to authorize it. |
- Adds `test:nowatch` script to packages containing tests for running vitest without watching files - Adds `cache: npm` arg to setup step for caching npm installs in CI jobs - Added test step before build step for early fail in CI before build step
mcanueste
force-pushed
the
add-test-step-to-ci
branch
from
6249516
to
533898d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test:nowatchscript to packages containing tests for running vitest without watching files.vitestcommand runs tests inwatchmode, so it waits for file changes. This is undesirable for CI, hence, thetest:nowatchscript.cache: npmarg to setup step for caching npm installs in CI jobs. Doesn't effect the testing, but a nice addition to cache npm installs to speed up CI for subsequent runs.NOTE: Related to task #663, so this PR should be merged first. It is not a blocker, but this PR runs tests only for
apps/gqlandpackages/gql-utilsas thetest:nowatchwas only added to those packages. The other packages containing test configuration will be removed after the PR since they don't have tests.Checklist
muroyoe#9144ci.ymlto include a test step after build #664npx turbo runat the root of the repository, and build was successful.npm install --save-exact <package>so my package is pinned to a specific npm version. Leave empty if no package was installed. Leave empty if no package was installed with this PR.How were these changes tested?
After the changes, I triggered the CI pipeline in my fork. See here for the pipeline outputs.