Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@apps/pano): Add home page #570

Merged
merged 19 commits into from
Jul 30, 2023
Merged

feat(@apps/pano): Add home page #570

merged 19 commits into from
Jul 30, 2023

Conversation

cansirin
Copy link
Contributor

@cansirin cansirin commented Jul 30, 2023

Description

Epic: #566
This PR is in progress but still open to review :)

Checklist

  • discord username: username#0001
  • Closes #
  • PR must be created for an issue from issues under "In progress" column from our project board.
  • A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules, and should include the app/package/service name in the title. For example, a title like "docs(@kampus-apps/pano): Add README.md" can be used.
  • Related file selection: Only relevant files should be touched and no other files should be affected.
  • I ran npx turbo run at the root of the repository, and build was successful.
  • I installed the npm packages using npm install --save-exact <package> so my package is pinned to a specific npm version. Leave empty if no package was installed. Leave empty if no package was installed with this PR.

How were these changes tested?

Please describe the tests you did to test the changes you made. Please also specify your test configuration.

@vercel
Copy link

vercel bot commented Jul 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kampus-gql ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2023 7:59am
kampus-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2023 7:59am
kampus-pasaport ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2023 7:59am
kampus-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2023 7:59am

Copy link
Member

@usirin usirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@usirin usirin merged commit d524b01 into dev Jul 30, 2023
@usirin usirin deleted the pano-next-home-page branch July 30, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants