diff --git a/debugfs.c b/debugfs.c index fb28cb04..fb5ec47b 100644 --- a/debugfs.c +++ b/debugfs.c @@ -364,10 +364,10 @@ static ssize_t mwl_debugfs_info_read(struct file *file, char __user *ubuf, "-----------------------=> address| address|qlen|fw_desc_cnt\n"); spin_lock_irqsave(&pcie_priv->tx_desc_lock, flags); len += scnprintf(p + len, size - len, - "wcb_base0 : %x => %8x|%8p|%4d|%d\n", get_hw_spec->wcb_base0, *((unsigned int *)le32_to_cpu(get_hw_spec->wcb_base0)),(void *)*((unsigned int *)le32_to_cpu(get_hw_spec->wcb_base0)),skb_queue_len(&pcie_priv->txq[0]),pcie_priv->fw_desc_cnt[0]); + "wcb_base0 : %x => %8zx|%8p|%4d|%d\n", get_hw_spec->wcb_base0, *((uintptr_t *)(uintptr_t)le32_to_cpu(get_hw_spec->wcb_base0)),(void *)*((uintptr_t *)(uintptr_t)le32_to_cpu(get_hw_spec->wcb_base0)),skb_queue_len(&pcie_priv->txq[0]),pcie_priv->fw_desc_cnt[0]); for(i = 0; i < SYSADPT_TOTAL_TX_QUEUES - 1; i++) len += scnprintf(p + len, size - len, - "wcb_base[%2d]: %x => %8x|%8p|%4d|%d\n", i, get_hw_spec->wcb_base[i], *((unsigned int *)le32_to_cpu(get_hw_spec->wcb_base[i])),(void *)*((unsigned int *)le32_to_cpu(get_hw_spec->wcb_base[i])),skb_queue_len(&pcie_priv->txq[i + 1]),pcie_priv->fw_desc_cnt[i + 1]); + "wcb_base[%2d]: %x => %8zx|%8p|%4d|%d\n", i, get_hw_spec->wcb_base[i], *((uintptr_t *)(uintptr_t)le32_to_cpu(get_hw_spec->wcb_base[i])),(void *)*((uintptr_t *)(uintptr_t)le32_to_cpu(get_hw_spec->wcb_base[i])),skb_queue_len(&pcie_priv->txq[i + 1]),pcie_priv->fw_desc_cnt[i + 1]); spin_unlock_irqrestore(&pcie_priv->tx_desc_lock, flags); } @@ -1342,7 +1342,7 @@ static ssize_t mwl_debugfs_regrdwr_read(struct file *file, char __user *ubuf, priv->reg_value); else len += scnprintf(p + len, size - len, - "error: %d(%u 0x%08x 0x%08x)\n", + "error: %zd(%u 0x%08x 0x%08x)\n", ret, priv->reg_type, priv->reg_offset, priv->reg_value); diff --git a/hif/fwcmd.c b/hif/fwcmd.c index fbd5df80..82138b81 100644 --- a/hif/fwcmd.c +++ b/hif/fwcmd.c @@ -3622,11 +3622,7 @@ int mwl_fwcmd_get_fw_core_dump(struct ieee80211_hw *hw, core_dump->context = pcmd->cmd_data.coredump.context; core_dump->size_kb = pcmd->cmd_data.coredump.size_kb; core_dump->flags = pcmd->cmd_data.coredump.flags; - memcpy(buff, - (const void *)((u32)pcmd + - sizeof(struct hostcmd_cmd_get_fw_core_dump) - - sizeof(struct hostcmd_cmd_get_fw_core_dump_)), - MAX_CORE_DUMP_BUFFER); + memcpy(buff, pcmd->buffer, MAX_CORE_DUMP_BUFFER); mutex_unlock(&priv->fwcmd_mutex); diff --git a/hif/pcie/8964/tx_ndp.c b/hif/pcie/8964/tx_ndp.c index 899d2493..96e09cb2 100644 --- a/hif/pcie/8964/tx_ndp.c +++ b/hif/pcie/8964/tx_ndp.c @@ -334,13 +334,8 @@ int pcie_tx_init_ndp(struct ieee80211_hw *hw) struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(&skb); int rc; - if (sizeof(struct pcie_tx_ctrl_ndp) > - sizeof(tx_info->driver_data)) { - wiphy_err(hw->wiphy, "driver data is not enough: %d (%d)\n", - sizeof(struct pcie_tx_ctrl_ndp), - sizeof(tx_info->driver_data)); - return -ENOMEM; - } + BUILD_BUG_ON(sizeof(struct pcie_tx_ctrl_ndp) > + sizeof(tx_info->driver_data)); rc = pcie_tx_ring_alloc_ndp(priv); if (rc) { diff --git a/hif/pcie/pcie.c b/hif/pcie/pcie.c index e55811f4..4c269cf1 100644 --- a/hif/pcie/pcie.c +++ b/hif/pcie/pcie.c @@ -1466,8 +1466,8 @@ static void pcie_bf_mimo_ctrl_decode(struct mwl_priv *priv, &fp_data->f_pos); filp_close(fp_data, current->files); } else { - wiphy_err(priv->hw->wiphy, "Error opening %s! %x\n", - filename, (unsigned int)fp_data); + wiphy_err(priv->hw->wiphy, "Error opening %s! %ld\n", + filename, PTR_ERR(fp_data)); } #if LINUX_VERSION_CODE < KERNEL_VERSION(5,10,0)