Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing composer.json #1

Open
gggeek opened this issue May 30, 2018 · 2 comments
Open

Missing composer.json #1

gggeek opened this issue May 30, 2018 · 2 comments

Comments

@gggeek
Copy link

gggeek commented May 30, 2018

As well as registration on packagist.org, which makes this package hard to install

The phar file could be tagged as executable in composer.json, so that it would be made available inside the main project bin folder for easy usage

@fvsch
Copy link
Contributor

fvsch commented May 30, 2018

That's an interesting approach.

The main downside is that I wanted the phar to be downloadable by people who are not comfortable with Composer. And I have another project where I’m trying to maintain both a composer-enabled lib and a downloadable zip in the same repo, and that's hard to manage. :/

For the record, for use in Symfony there is this equivalent bundle published on Packagist:
https://github.com/kaliop/twig-express-bundle

@gggeek
Copy link
Author

gggeek commented May 30, 2018

Well, adding Composer support does not mean that a phar (or zip) file can not be downloaded standalone :-) In fact removing dependencies from the source would make it easier to build the zip file, as you could more or less simply zip up the whole dir, no?
Also, composer is not only used by Symfony devs :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants