Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh install is not working #251

Open
StarNab opened this issue Nov 4, 2022 · 5 comments
Open

Fresh install is not working #251

StarNab opened this issue Nov 4, 2022 · 5 comments
Labels

Comments

@StarNab
Copy link

StarNab commented Nov 4, 2022

After a fresh install of the bundle (v.6.2) on an ez Platform website (5.4), we get the following error :
` [Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException]

Circular reference detected for service "ez_migration_bundle.reference_resolver.customreference.flexible", path: "ez_migration_bundle.reference_resolver.customreference.flexible -> ez_migration_bundle.reference_resolver.expression -> ez_migration_bundle.re

ference_resolver.customreference.flexible".`

Whereas version 5.15 is working

@gggeek
Copy link
Member

gggeek commented Nov 4, 2022

I will take a look. It is strange that this is not being surfaced by the CI tests... The eZ version you are using is eZPublishPlatform EE 5.4, correct?

@gggeek
Copy link
Member

gggeek commented Nov 4, 2022

PS: in the meanwhile, could you try tagging the ez_migration_bundle.reference_resolver.expression service as lazy ?

EDIT: this should already be the case. I wonder why it is not enough to break the circular dependency exception...

@gggeek gggeek added the bug label Nov 16, 2022
@gggeek
Copy link
Member

gggeek commented Nov 16, 2022

PPS: in case you are not interested in using eval: to create values dynamically based on references, you should also be able to work around the circular service dependency error by redefining in your app's config the following service:

    ez_migration_bundle.reference_resolver.customreference.flexible:
        class: '%ez_migration_bundle.reference_resolver.chain_prefix.class%'
        arguments:
            -
                - '@ez_migration_bundle.reference_resolver.customreference.base'
                - '@ez_migration_bundle.reference_resolver.loop'
                # comment this out
                #- '@ez_migration_bundle.reference_resolver.expression'

@gggeek
Copy link
Member

gggeek commented Nov 22, 2022

Note: I tried reproducing the problem you mention by running the bundle's testsuite on eZP CP ~2014.11.1, with COMPOSER_PREFER_LOWEST=1 to try to get installed the oldest possible version of all dependencies, and I still can not reproduce it.

If this is still an issue, would it be possible for you to share the composer.lock file?

@gggeek
Copy link
Member

gggeek commented Apr 19, 2023

Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants