Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load dragula from NPM instead of Bower #29

Open
oskarrough opened this issue Jun 4, 2017 · 5 comments
Open

Load dragula from NPM instead of Bower #29

oskarrough opened this issue Jun 4, 2017 · 5 comments
Labels
enhancement help wanted

Comments

@oskarrough
Copy link
Contributor

As bower is being phased out of ember-cli we should move the dragula dependency to NPM. And make sure it is not loaded in Fastboot environments.
@kkincade
Copy link

kkincade commented Jun 28, 2017 •
edited
Loading

Is there any plan to do this in the near future? Looks like the PR is ready.

@oskarrough
Copy link
Contributor Author

oskarrough commented Jun 29, 2017 •
edited
Loading

@kkincade yes I started it here #30.

But I'm honestly not sure if I missed something. Ah, I merged it to master now to get the ball moving. Do you have the chance to test it out from master? Before we push a release, that is.

@jeanduplessis jeanduplessis mentioned this issue Jul 7, 2017
Closed
@ro0gr
Copy link

ro0gr commented Feb 28, 2018 •
edited
Loading

@oskarrough I think it doesn't work currently.

@ro0gr
Copy link

ro0gr commented Feb 28, 2018

@oskarrough would you accept a pr fixing this?

@ro0gr ro0gr mentioned this issue Feb 28, 2018
Closed
@oskarrough
Copy link
Contributor Author

@ro0gr definitely. A PR would be very much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dragula dependency into vendor tree SameWave/ember-dragula
3 participants
@oskarrough @ro0gr @kkincade