Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ClientChunkWriter #84

Open
wyatt-herkamp opened this issue Dec 19, 2020 · 0 comments
Open

Rewrite ClientChunkWriter #84

wyatt-herkamp opened this issue Dec 19, 2020 · 0 comments
Assignees
Labels
game performance Changes that could result in higher performance
Milestone

Comments

@wyatt-herkamp
Copy link
Member

wyatt-herkamp commented Dec 19, 2020

The ClientChunkWriter located here needs to be gone through and cleaned up.

@ryandw11 if you could go through and update it to be optimized for ODS the correct way. You might also need to make changes to Kakara/Core.

I have changed the API to allow writes on a per block basis. You spoke of this idea the other day.
You also said that maybe instead of compressing the file we compress the chunk.

I do want to let you know. Kakara ChunkIO automatically splits up chunk loads so they are done a per file basis inside so inside ChunkWriter#writeChunks(List chunks) my thought the best way to do is to limit file rewrites. However, I am not sure.

@wyatt-herkamp wyatt-herkamp added game performance Changes that could result in higher performance labels Dec 19, 2020
@wyatt-herkamp wyatt-herkamp added this to the 1.0-PreBeta milestone Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
game performance Changes that could result in higher performance
Projects
None yet
Development

No branches or pull requests

2 participants