Dockefiles should separate the base image from the "build strategy" (aka flavor) #1898
Closed
Assignees
Comments
This was referenced Oct 9, 2023
Closed
Merged
9 tasks
jimmykarily
pushed a commit
that referenced
this issue
Oct 19, 2023
Fixes #1898 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
pushed a commit
that referenced
this issue
Oct 19, 2023
Fixes #1898 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
pushed a commit
that referenced
this issue
Oct 20, 2023
Fixes #1898 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
pushed a commit
that referenced
this issue
Oct 23, 2023
Fixes #1898 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
pushed a commit
that referenced
this issue
Oct 23, 2023
Fixes #1898 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
pushed a commit
that referenced
this issue
Oct 24, 2023
Fixes #1898 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
that referenced
this issue
Oct 24, 2023
* Refactor flavors and dockerfiles Fixes #1898 Signed-off-by: Dimitris Karakasilis <[email protected]> * Use FRAMEWORK_FLAVOR variable to avoid confusion with FLAVOR Signed-off-by: Dimitris Karakasilis <[email protected]> * Fix pipeline by adding mandatory value Signed-off-by: Dimitris Karakasilis <[email protected]> * Fix ubuntu Dockerfile Signed-off-by: Dimitris Karakasilis <[email protected]> * Apply suggestions from code review Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove TODO (already implemented) and non-used ARG "IMAGE" Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove TODOs moved here: #1897 (comment) Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove unecessary env variables and fix VARIANT_RELEASE missing Signed-off-by: Dimitris Karakasilis <[email protected]> * PR comments Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove naming.sh script from base image Signed-off-by: Dimitris Karakasilis <[email protected]> * Make sure we use the "fixed" kairos version with the remove "+" symbols when creating a tag for container images. Signed-off-by: Dimitris Karakasilis <[email protected]> * Setup qemu and docker buildx in reusable-build-flavor workflow because otherwise it fails to build rpi images Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove not needed env variables Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove temporary change Signed-off-by: Dimitris Karakasilis <[email protected]> --------- Signed-off-by: Dimitris Karakasilis <[email protected]> Signed-off-by: Dimitris Karakasilis <[email protected]> Co-authored-by: Mauro Morales <[email protected]>
github-project-automation
bot
moved this from Under review 🔍
to Done ✅
in 🧙Issue tracking board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently setting the flavor when building a kairos dockerfile, sets both the base image and the building steps (the "strategy"). In other words, we decide what packages to install and what modifications to make based on the flavor.
We should allow the users to specify a base image and a strategy. For example:
"Build on top of
ubuntu_my_custom_buildas if you were buildingubuntu 20.04. In this example, "ubuntu 20.04" becomes the build strategy, andubuntu_my_custom_buildis the base image.Part of: #116
The text was updated successfully, but these errors were encountered: