cppzst (2.0.6) version breaks package

[radosstojkonsoft]

cppzst (2.0.6) version breaks package
Can you please upgrade cppzst dependency to latest version (2.0.12)

zstd/package.json

Line 41 in c8d3e2a

"cppzst": "2.0.6"

[ankon]

Could you provide also some details about how things are broken?

• Console output, error messages, ...?
• Environment information such as operating system, NodeJS version, compiler version?

This will help other people googling their symptoms and direct them here.

[JSimoni42]

I may have the same issue here. I'm trying to install kafkajs/zstd on a Linux-based GitHub actions runner and getting errors from node-gyp. Logs from npm install included below:

npm ERR! code 1
npm ERR! path /home/runner/work/jarvis/jarvis/call-performance-event-ingestor/node_modules/@kafkajs/zstd/node_modules/cppzst
npm ERR! command failed
npm ERR! command sh -c node-gyp rebuild
npm ERR! make: Entering directory '/home/runner/work/jarvis/jarvis/call-performance-event-ingestor/node_modules/@kafkajs/zstd/node_modules/cppzst/build'
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/common/debug.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/common/entropy_common.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/common/error_private.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/common/fse_decompress.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/common/pool.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/common/threading.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/common/xxhash.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/common/zstd_common.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/fse_compress.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/hist.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/huf_compress.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/zstd_compress.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/zstd_compress_literals.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/zstd_compress_sequences.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/zstd_compress_superblock.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/zstd_double_fast.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/zstd_fast.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/zstd_lazy.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/zstd_ldm.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/zstd_opt.o
npm ERR!   CC(target) Release/obj.target/compress/deps/zstd/lib/compress/zstdmt_compress.o
npm ERR! rm -f Release/obj.target/deps/compress.a Release/obj.target/deps/compress.a.ar-file-list; mkdir -p `dirname Release/obj.target/deps/compress.a`
npm ERR! ar crs Release/obj.target/deps/compress.a @Release/obj.target/deps/compress.a.ar-file-list
npm ERR!   COPY Release/compress.a
npm ERR!   CXX(target) Release/obj.target/compressor/src/common/stream_coder.o
npm ERR! make: Leaving directory '/home/runner/work/jarvis/jarvis/call-performance-event-ingestor/node_modules/@kafkajs/zstd/node_modules/cppzst/build'
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using [email protected]
npm ERR! gyp info using [email protected] | linux | x64
npm ERR! gyp info find Python using Python version 3.10.12 found at "/usr/bin/python3"
npm ERR! gyp info spawn /usr/bin/python3
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args   '/opt/hostedtoolcache/node/18.16.0/x64/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args   'binding.gyp',
npm ERR! gyp info spawn args   '-f',
npm ERR! gyp info spawn args   'make',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/home/runner/work/jarvis/jarvis/call-performance-event-ingestor/node_modules/@kafkajs/zstd/node_modules/cppzst/build/config.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/opt/hostedtoolcache/node/18.16.0/x64/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/home/runner/.cache/node-gyp/18.16.0/include/node/common.gypi',
npm ERR! gyp info spawn args   '-Dlibrary=shared_library',
npm ERR! gyp info spawn args   '-Dvisibility=default',
npm ERR! gyp info spawn args   '-Dnode_root_dir=/home/runner/.cache/node-gyp/18.16.0',
npm ERR! gyp info spawn args   '-Dnode_gyp_dir=/opt/hostedtoolcache/node/18.16.0/x64/lib/node_modules/npm/node_modules/node-gyp',
npm ERR! gyp info spawn args   '-Dnode_lib_file=/home/runner/.cache/node-gyp/18.16.0/<(target_arch)/node.lib',
npm ERR! gyp info spawn args   '-Dmodule_root_dir=/home/runner/work/jarvis/jarvis/call-performance-event-ingestor/node_modules/@kafkajs/zstd/node_modules/cppzst',
npm ERR! gyp info spawn args   '-Dnode_engine=v8',
npm ERR! gyp info spawn args   '--depth=.',
npm ERR! gyp info spawn args   '--no-parallel',
npm ERR! gyp info spawn args   '--generator-output',
npm ERR! gyp info spawn args   'build',
npm ERR! gyp info spawn args   '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! gyp info spawn make
npm ERR! gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm ERR! In file included from /home/runner/.cache/node-gyp/18.16.0/include/node/v8-local-handle.h:12,
npm ERR!                  from /home/runner/.cache/node-gyp/18.16.0/include/node/v8-array-buffer.h:12,
npm ERR!                  from /home/runner/.cache/node-gyp/18.16.0/include/node/v8.h:24,
npm ERR!                  from /home/runner/.cache/node-gyp/18.16.0/include/node/node.h:[7](https://github.com/hiyainc/jarvis/actions/runs/8515338076/job/23322628260?pr=1070#step:7:8)3,
npm ERR!                  from ../../../../../nan/nan.h:62,
npm ERR!                  from ../src/common/stream_coder.h:4,
npm ERR!                  from ../src/common/stream_coder.cc:1:
npm ERR! /home/runner/.cache/node-gyp/1[8](https://github.com/hiyainc/jarvis/actions/runs/8515338076/job/23322628260?pr=1070#step:7:9).16.0/include/node/v8-internal.h: In function ‘void v8::internal::PerformCastCheck(T*)’:
npm ERR! /home/runner/.cache/node-gyp/18.16.0/include/node/v8-internal.h:646:38: error: ‘remove_cv_t’ is not a member of ‘std’; did you mean ‘remove_cv’?
npm ERR!   646 |             !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
npm ERR!       |                                      ^~~~~~~~~~~
npm ERR!       |                                      remove_cv
npm ERR! /home/runner/.cache/node-gyp/18.16.0/include/node/v8-internal.h:646:38: error: ‘remove_cv_t’ is not a member of ‘std’; did you mean ‘remove_cv’?
npm ERR!   646 |             !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
npm ERR!       |                                      ^~~~~~~~~~~
npm ERR!       |                                      remove_cv
npm ERR! /home/runner/.cache/node-gyp/18.16.0/include/node/v8-internal.h:646:50: error: template argument 2 is invalid
npm ERR!   646 |             !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
npm ERR!       |                                                  ^
npm ERR! /home/runner/.cache/node-gyp/18.16.0/include/node/v8-internal.h:646:63: error: ‘::Perform’ has not been declared
npm ERR!   646 |             !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
npm ERR!       |                                                               ^~~~~~~
npm ERR! make: *** [compressor.target.mk:126: Release/obj.target/compressor/src/common/stream_coder.o] Error 1
npm ERR! gyp ERR! build error 
npm ERR! gyp ERR! stack Error: `make` failed with exit code: 2
npm ERR! gyp ERR! stack     at ChildProcess.onExit (/opt/hostedtoolcache/node/18.16.0/x64/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:203:23)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:513:28)
npm ERR! gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:2[9](https://github.com/hiyainc/jarvis/actions/runs/8515338076/job/23322628260?pr=1070#step:7:10)1:12)
npm ERR! gyp ERR! System Linux 6.5.0-[10](https://github.com/hiyainc/jarvis/actions/runs/8515338076/job/23322628260?pr=1070#step:7:11)16-azure
npm ERR! gyp ERR! command "/opt/hostedtoolcache/node/18.16.0/x64/bin/node" "/opt/hostedtoolcache/node/18.16.0/x64/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd /home/runner/work/jarvis/jarvis/call-performance-event-ingestor/node_modules/@kafkajs/zstd/node_modules/cppzst
npm ERR! gyp ERR! node -v v18.16.0
npm ERR! gyp ERR! node-gyp -v v9.3.1
npm ERR! gyp ERR! not ok

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2024-04-02T00_05_42_265Z-debug-0.log

[dnychennnn]

can also confirm this issue on my side.

[sumitmitra255]

Please upgrade to latest cppzst

[davidconvista]

Is there any update on this? I am trying to install the package, but it fails all the time :(