Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose mappersmith's full capabilities #22

Open
erikengervall opened this issue Oct 25, 2019 · 3 comments
Open

Expose mappersmith's full capabilities #22

erikengervall opened this issue Oct 25, 2019 · 3 comments

Comments

@erikengervall
Copy link
Collaborator

erikengervall commented Oct 25, 2019

The original discussion was spawned in #20.

The question is whether or not to expose more of mappersmith's internal capabilities to allow users to leverage its features.

Pros

  • Users get access to the full list of capabilities offered by mappersmith, primarily middlewares

Cons

  • It would lock v1.x.x to mappersmith and a change in http client would require a major version bump
@erikengervall erikengervall changed the title Discussion: Expose mappersmith's full capabilities Expose mappersmith's full capabilities Nov 28, 2019
@khajvahmac
Copy link

khajvahmac commented May 18, 2022

Bumping this thread. Are there any updates regarding this? Our use case is, we need to pass a authorization header. Custom middleware would do the trick but there is the exposure of mappersmith's middleware API which I think is a bit of overkill, as there shouldn't be too much need for request manipulation.

Maybe we can have a custom headers support? That should cover most of the authentication needs and not expose implementation detail.

@mbuotidem
Copy link

@erikengervall Do you know if there's a plan to implement this? I have the same use case as @khajvahmac and its also come up in #239. @khajvahmac did you find a workaround for this you could share?

@toanvc
Copy link

toanvc commented Aug 9, 2023

@mbuotidem hello I created a PR here #249 for the workaround in our project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants