From e9b87fb05a09dc1a20df2fc40b02ebe80de79a92 Mon Sep 17 00:00:00 2001 From: Tomofumi Hayashi Date: Wed, 12 Oct 2022 01:31:15 +0900 Subject: [PATCH] Fix release 3.x thick image tag to isolate from 4.0 Due to #900, image tag, ':thick', which is used in 4.0 and 3.x, gets user confused because thick image is not compatible between 4.0 and 3.x. This fix provides strict version name in deployment yaml to specify install image tag. --- .github/workflows/image-push-release.yml | 2 +- deployments/multus-daemonset-thick-plugin.yml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/image-push-release.yml b/.github/workflows/image-push-release.yml index 5c569171e..fb4589733 100644 --- a/.github/workflows/image-push-release.yml +++ b/.github/workflows/image-push-release.yml @@ -47,7 +47,7 @@ jobs: context: . push: true tags: | - ghcr.io/${{ github.repository }}:thick-amd64 + ghcr.io/${{ github.repository }}:stable-thick-amd64 ${{ steps.docker_meta.outputs.tags }}-thick-amd64 file: images/Dockerfile.thick diff --git a/deployments/multus-daemonset-thick-plugin.yml b/deployments/multus-daemonset-thick-plugin.yml index 6f484c588..4698284d2 100644 --- a/deployments/multus-daemonset-thick-plugin.yml +++ b/deployments/multus-daemonset-thick-plugin.yml @@ -122,7 +122,7 @@ spec: serviceAccountName: multus containers: - name: kube-multus - image: ghcr.io/k8snetworkplumbingwg/multus-cni:thick + image: ghcr.io/k8snetworkplumbingwg/multus-cni:v3.9.2-thick-amd64 command: [ "/usr/src/multus-cni/bin/multus-daemon" ] args: - "-cni-version=0.3.1" @@ -146,7 +146,7 @@ spec: mountPath: /host/opt/cni/bin initContainers: - name: install-multus-binary - image: ghcr.io/k8snetworkplumbingwg/multus-cni:thick + image: ghcr.io/k8snetworkplumbingwg/multus-cni:v3.9.2-thick-amd64 command: - "cp" - "/usr/src/multus-cni/bin/multus" @@ -162,7 +162,7 @@ spec: mountPath: /host/opt/cni/bin mountPropagation: Bidirectional - name: generate-kubeconfig - image: ghcr.io/k8snetworkplumbingwg/multus-cni:thick + image: ghcr.io/k8snetworkplumbingwg/multus-cni:v3.9.2-thick-amd64 command: - "/usr/src/multus-cni/bin/generate-kubeconfig" args: