-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for NodeExternalDNS #10848
Comments
It's not undocumented, it is covered here : https://pkg.go.dev/k8s.io/api/core/v1#NodeAddressType
We don't currently support setting either of the DNS types, just hostname and internal/external IPs. |
@VestigeJ I haven't backported this yet, please reopen the backports. On the release branches, I suspect that the config file entry is being ignored and the external lookups you're testing with are returning public lookups instead of resolving to the node address as you would expect if this was working. |
Missed backports again this month because it was Done. Have rescheduled the backports for December and moved back to Working. |
Is your feature request related to a problem? Please describe.
I am using Agones in my cluster and the GameServer resources can resolve their address to NodeExternalDNS as seen here:
https://github.com/googleforgames/agones/blob/02e57babccab6489b18d956286152174fe9a1eaa/pkg/gameservers/gameservers.go#L46
however, the entry on k3s is unpopulated - only NodeExternalIP can be resolved with the --node-external-ip flag when launching k3s server.
Describe the solution you'd like
A cli option like
k3s server --node-external-dns example.com
similar to --node-external-ipDescribe alternatives you've considered
I am currently using --node-external-ip and look up the server domains by comparing with that ip in a local configuration.
Additional context
It seems undocumented that NodeExternalDNS is a valid status entry on node types. I opened a PR there kubernetes/api#77 on k8s core v1 API Node Address type.
The text was updated successfully, but these errors were encountered: