Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NodeExternalDNS #10848

Open
arnemileswinter opened this issue Sep 6, 2024 · 3 comments
Open

Support for NodeExternalDNS #10848

arnemileswinter opened this issue Sep 6, 2024 · 3 comments
Assignees

Comments

@arnemileswinter
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I am using Agones in my cluster and the GameServer resources can resolve their address to NodeExternalDNS as seen here:
https://github.com/googleforgames/agones/blob/02e57babccab6489b18d956286152174fe9a1eaa/pkg/gameservers/gameservers.go#L46

however, the entry on k3s is unpopulated - only NodeExternalIP can be resolved with the --node-external-ip flag when launching k3s server.

Describe the solution you'd like
A cli option like k3s server --node-external-dns example.com similar to --node-external-ip

Describe alternatives you've considered
I am currently using --node-external-ip and look up the server domains by comparing with that ip in a local configuration.

Additional context
It seems undocumented that NodeExternalDNS is a valid status entry on node types. I opened a PR there kubernetes/api#77 on k8s core v1 API Node Address type.

@brandond
Copy link
Member

brandond commented Sep 6, 2024

It's not undocumented, it is covered here : https://pkg.go.dev/k8s.io/api/core/v1#NodeAddressType

	// NodeInternalDNS identifies a DNS name which resolves to an IP address which has
	// the characteristics of a NodeInternalIP. The IP it resolves to may or may not
	// be a listed NodeInternalIP address.
	NodeInternalDNS [NodeAddressType](https://pkg.go.dev/k8s.io/api/core/v1#NodeAddressType) = "InternalDNS"

	// NodeExternalDNS identifies a DNS name which resolves to an IP address which has
	// the characteristics of a NodeExternalIP. The IP it resolves to may or may not
	// be a listed NodeExternalIP address.
	NodeExternalDNS [NodeAddressType](https://pkg.go.dev/k8s.io/api/core/v1#NodeAddressType) = "ExternalDNS"

We don't currently support setting either of the DNS types, just hostname and internal/external IPs.

@brandond
Copy link
Member

brandond commented Oct 8, 2024

@VestigeJ I haven't backported this yet, please reopen the backports. On the release branches, I suspect that the config file entry is being ignored and the external lookups you're testing with are returning public lookups instead of resolving to the node address as you would expect if this was working.

@mdrahman-suse mdrahman-suse reopened this Nov 14, 2024
@mdrahman-suse mdrahman-suse moved this from Done Issue to To Test in K3s Development Nov 14, 2024
@brandond brandond moved this from To Test to Working in K3s Development Nov 14, 2024
@brandond
Copy link
Member

brandond commented Nov 14, 2024

Missed backports again this month because it was Done. Have rescheduled the backports for December and moved back to Working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Working
Development

No branches or pull requests

4 participants