Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link contributing guide in README #331

Open
recursivetree opened this issue Oct 4, 2024 · 2 comments
Open

Link contributing guide in README #331

recursivetree opened this issue Oct 4, 2024 · 2 comments

Comments

@recursivetree
Copy link
Contributor

While submitting a PR to this repo, I was asked to add Signed-Off-By: <email> before it can be merged. This requirement is not mentioned in the readme of this repository (compared to e.g. https://github.com/k3s-io/k3s/blob/master/README.md#contributing).

I'd suggest to either copy or link the contributing guidelines in this repo.

@brandond
Copy link
Member

brandond commented Oct 4, 2024

fwiw, DCO is required for contribution to all CNCF projects. We could add it to the readme though.

@recursivetree
Copy link
Contributor Author

This might be obvious to long-term k3s and CNCF contributors, but to a first-time contributor that is not involved in other CNCF projects, it is no obvious fact.

On the other hand, I do agree that it is not the end of the world if a link to the contribution policy is missing. I also don't want to complain about the policy itself, that is up to the k3s team and not me. I'm writing this as feedback to hopefully make the process of contributing more smooth for the next person in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants