Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remediation is failing when machine bootstrap failed #108

Closed
nasusoba opened this issue May 8, 2024 · 0 comments · Fixed by #109
Closed

Remediation is failing when machine bootstrap failed #108

nasusoba opened this issue May 8, 2024 · 0 comments · Fixed by #109

Comments

@nasusoba
Copy link
Contributor

nasusoba commented May 8, 2024 •
edited
Loading

After #103 , the machine remediation process is failing if machine bootstrap failed and node did not join the cluster successfully. The reason is that we have not handled the case when machine.Status.NodeRef = nil when handling PreTerminateDeleteHook. Working on the fix....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix KCP remediation & add machine deployment remediation test nasusoba/cluster-api-k3s
1 participant
@nasusoba