Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow types in NPM package causing Flow errors in projects #1

Closed
cburbank opened this issue Oct 7, 2018 · 1 comment
Closed

Flow types in NPM package causing Flow errors in projects #1

cburbank opened this issue Oct 7, 2018 · 1 comment
Assignees
@cburbank
Labels
bug Something isn't working

Comments

@cburbank
Copy link
Contributor

cburbank commented Oct 7, 2018

Currently the build process includes a copy of the un-transpiled source files with the Flow types intact. This is causing Flow errors in projects where this package is imported.

Temporary solution: No longer include the *.js.flow files in the NPM package

  • Disable the build step that copies the src files to the lib directory

Long-term solution: Figure out a better way to include flow types with the package
@cburbank cburbank added the bug Something isn't working label Oct 7, 2018
@cburbank cburbank self-assigned this Oct 7, 2018
cburbank added a commit that referenced this issue Oct 7, 2018
@cburbank
[#1]: remove creation of *.js.flow files from build process
2a3e4ae
@cburbank
Copy link
Contributor Author

cburbank commented Oct 7, 2018

Released with v2.0.1

@cburbank cburbank closed this as completed Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cburbank cburbank

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cburbank