Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reduce gem size #486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frezbo
Copy link

@frezbo frezbo commented Sep 13, 2019

This tries to reduce the gem dependencies to only what is being used.

Signed-off-by: Noel Georgi <[email protected]>
@k1LoW
Copy link
Owner

k1LoW commented Sep 15, 2019

Hi @frezbo Thank you for you commit!!

I have one question. Why do you want to reduse the gem dependencies ?

I think it's more important to be easier when someone adds a new resource than the size of the gem.

@frezbo
Copy link
Author

frezbo commented Sep 17, 2019

@k1LoW Yes I agree to the ease of adding a new gem, but the existing code also means that any gem project depending on awspec also gets all the unwanted aws dependencies. I will leave it up to the authors on the final decision. I'm still ok keeping all considering supporting new resources.

@frezbo frezbo closed this Sep 17, 2019
@frezbo frezbo reopened this Sep 17, 2019
@k1LoW
Copy link
Owner

k1LoW commented Sep 18, 2019

@frezbo Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants