Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let temporary untar dirs start with a dot #4487

Merged
merged 1 commit into from
May 27, 2024
Merged

Let temporary untar dirs start with a dot #4487

merged 1 commit into from
May 27, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented May 24, 2024

So that they are ignored by the Go tooling. Otherwise, when building in parallel, Go may try to treat these temporary directories as Go package folders and fail utterly.

https://pkg.go.dev/cmd/go#hdr-Package_lists_and_patterns

Directory and file names that begin with "." or "_" are ignored by the go tool, as are directories named "testdata".

Fixes:

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Let temporary untar dirs start with a dot
db51280 
So that they are ignored by the Go tooling. Otherwise, when building in
parallel, Go may try to treat these temporary directories as Go package
folders and fail utterly.

https://pkg.go.dev/cmd/go#hdr-Package_lists_and_patterns

> Directory and file names that begin with "." or "_" are ignored by the
> go tool, as are directories named "testdata".

Fixes: d68dc34 ("Improve Docker export in embedded-binaries Makefile")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added bug Something isn't working backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch labels May 24, 2024
@twz123 twz123 marked this pull request as ready for review May 24, 2024 10:33
@twz123 twz123 requested a review from a team as a code owner May 24, 2024 10:33
@twz123 twz123 requested review from ncopa and juanluisvaladas May 24, 2024 10:33
@twz123 twz123 merged commit 2fe89ce into k0sproject:main May 27, 2024
80 checks passed
@twz123 twz123 deleted the ignore-embedded-bins-tardirs branch May 27, 2024 10:26
@k0s-bot
Copy link

k0s-bot commented May 27, 2024

Successfully created backport PR for release-1.30:

@k0s-bot k0s-bot mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanluisvaladas juanluisvaladas juanluisvaladas approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twz123 @k0s-bot @juanluisvaladas