Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubeconfig API endpoint #4033

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Feb 6, 2024

Description

Since the refactoring to use Calico host containers on Windows, there's no need for this endpoint anymore. Remove it along with its associated bootstrap token usage. Also, replace the API authorization based on the k0s "role" with an authorization based directly on the bootstrap token usages, since only the "controller" role was left.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Since the refactoring to use Calico host containers on Windows, there's
no need for this endpoint anymore. Remove it along with its associated
bootstrap token usage. Also, replace the API authorization based on the
k0s "role" with an authorization based directly on the bootstrap token
usages, since only the "controller" role was left.

See: bb7b580 ("Helper to get correct node name for windows")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review February 6, 2024 16:21
@twz123 twz123 requested a review from a team as a code owner February 6, 2024 16:21
@twz123 twz123 requested review from kke and juanluisvaladas February 6, 2024 16:21
@twz123 twz123 merged commit 691d6e0 into k0sproject:main Feb 19, 2024
75 checks passed
@twz123 twz123 deleted the remove-kubeconfig-api-endpoint branch February 19, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants