Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pre-shared token creation #4025

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Refactor pre-shared token creation #4025

merged 2 commits into from
Feb 5, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Feb 5, 2024

Description

Extract the BootstrapToken secret generation into a separate function and use that when creating pre-shared tokens. This replaces the fake client workaround for the missing API and uses a more straightforward approach. Reduces the binary size by about 2 MiB.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

twz123 added 2 commits February 5, 2024 13:04
@twz123
Extract BootstrapToken secret generation in its own function
c28d96e 
This allows the secret to be created without creating it in the cluster.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Use RandomBootstrapSecret to generate preshared tokens
c2c801c 
Replace the fake client workaround for the missing API and use a
straight-forward approach to get the secret and token.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added the chore label Feb 5, 2024
@twz123 twz123 marked this pull request as ready for review February 5, 2024 15:09
@twz123 twz123 requested a review from a team as a code owner February 5, 2024 15:09
@twz123 twz123 requested review from kke and juanluisvaladas February 5, 2024 15:09
@twz123 twz123 merged commit 3a518d8 into k0sproject:main Feb 5, 2024
74 checks passed
@twz123 twz123 deleted the preshared branch February 5, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanluisvaladas juanluisvaladas juanluisvaladas approved these changes

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @juanluisvaladas