Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use downloaded cosign binary in release workflow #3970

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 24, 2024

Description

This simplifies its usage, as Docker is not required. Also fixes the CURDIR issue:

/runner/_work/_temp/942db570-3c25-43c3-8cce-9dbabc9f9633.sh: line 2: CURDIR: command not found
docker: invalid spec: :/k0s: empty section between colons.
See 'docker run --help'.

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

This simplifies its usage, as Docker is not required. Also fixes the
CURDIR issue:

    /runner/_work/_temp/942db570-3c25-43c3-8cce-9dbabc9f9633.sh: line 2: CURDIR: command not found
    docker: invalid spec: :/k0s: empty section between colons.
    See 'docker run --help'.

Fixes: 51a9263 ("Signing k0s binaries with cosign")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added bug Something isn't working area/ci labels Jan 24, 2024
@twz123 twz123 marked this pull request as ready for review January 24, 2024 11:48
@twz123 twz123 requested a review from a team as a code owner January 24, 2024 11:48
@twz123 twz123 requested review from kke and makhov January 24, 2024 11:48
@twz123 twz123 enabled auto-merge January 24, 2024 11:48
Copy link
Contributor

@kke kke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if it doesn't work, just recreate the tag.

@twz123 twz123 merged commit 1b2a9c5 into k0sproject:main Jan 24, 2024
75 checks passed
@twz123 twz123 deleted the download-cosign branch January 24, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants