Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop k0sctl integration test #3960

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 19, 2024

Description

The k0s CI uses k0sctl in several places these days: The nightly check-network workflow, the OS testing matrix, and most importantly, the release pipeline. The individual k0sctl integration test is no longer needed.

@k0sproject/k0s-maintainers feel free to close the PR if you'd prefer to keep the test.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

The k0s CI uses k0sctl in several places these days: The nightly
check-network workflow, the OS testing matrix, and most importantly, the
release pipeline. The individual k0sctl integration test is no longer
needed.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 requested a review from a team as a code owner January 19, 2024 15:37
@twz123 twz123 requested review from kke and jnummelin January 19, 2024 15:37
@twz123 twz123 merged commit 2a5c565 into k0sproject:main Jan 27, 2024
73 checks passed
@twz123 twz123 deleted the drop-k0sctl-inttest branch January 27, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants