-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac executable is not statically linked #100
Comments
Indeed, it doesn't work at all even though I have
I tried linking the library forcefully, but the architectures aren't compatible:
|
Ran into the same issue:
Root cause is that on newer macs (like the M1, M2 ones), homebrew is not installed under |
Huh, formula is pretty basic: https://github.com/jzelinskie/homebrew-faq/blob/master/Formula/faq.rb So I guess the problem is not how the formula passes the libjq dependency, but that it doesn't pass it at all! Because faq is not built by homebrew so it can pass the prefix, but instead built by github actions assuming libjq is always found under I think the fix should probably be to have the Formula build the binary instead of downloading the binary from github. |
The pre-built binary the formula downloaded is broken when used on newer macs where the homebrew prefix is not `/usr/local` but `/opt/homebrew`. The formula should rely on homebrew telling where the library is, and build with CGO using that info. To avoid incompatible installs, use the `bottle` mechanism of homebrew to fetch prebuilt packages (eg. for older macos versions and architectures), and leave installation by rebuilds open to newer architectures not having prebuilt bottles. Fixes jzelinskie/faq#100
Pushed a fix for the homebrew formula to build from source instead of fetching pre-built binaries with faulty dynamic linking. |
I'm only filing this because the README states that they are:
The text was updated successfully, but these errors were encountered: