Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve curl_multi explaination (L27) #17

Open
alainlou opened this issue Dec 20, 2020 · 0 comments
Open

[Enhancement] Improve curl_multi explaination (L27) #17

alainlou opened this issue Dec 20, 2020 · 0 comments

Comments

@alainlou
Copy link

The description for curl_multi was a little confusing - I think it'd be good to go over a high-level description of the internal working of curl_multi (or maybe the pattern of an asynchronous event loop in general) to help us better understand what's going on.

I know you mentioned that we use asynchronous when multi-threaded is not an option, but I thought maybe this was because curl_multi used pthreads internally more efficiently or something.

There were a few points in the lecture that I felt suggested curl_multi used pthreads internally:
https://youtu.be/CTL6JjFljZw?t=86 (not to be harsh, but this was not only a bad joke, it was confusing too tbh)
https://youtu.be/CTL6JjFljZw?t=395 ("we dispatch all easy handles at once")

Perhaps it would also be good to talk about when and how our callback is actually called by curl_multi.

Some relevant Piazza discussions:
https://piazza.com/class/kebv6ghs3ahfo?cid=613
https://piazza.com/class/kebv6ghs3ahfo?cid=530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant