Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent failure if WebAuthn key name is omitted #43

Open
justinmayer opened this issue Oct 2, 2020 · 0 comments
Open

Silent failure if WebAuthn key name is omitted #43

justinmayer opened this issue Oct 2, 2020 · 0 comments

Comments

@justinmayer
Copy link
Owner

Steps to Reproduce

  1. Log in and choose “Manage WebAuthn keys”
  2. Tap the appropriate link to add a key
  3. Without entering a key name, tap the “Add WebAuthn Key” button.

Expected Result

Using the same browser-based validation that occurs in other parts of Kagi’s form validation, the browser would indicate that a key name must be provided.

Observed Result

Nothing visible happens. In the browser console, the following output is displayed:

**XHR** POST http://localhost:8000/kagi/api/begin-activate/ [HTTP/1.1 400 Bad Request 42ms]

Uncaught (in promise) TypeError: credentialCreateOptionsFromServer.user is undefined
    transformCredentialCreateOptions http://localhost:8000/static/kagi/webauthn.js:155
    didClickRegister http://localhost:8000/static/kagi/webauthn.js:68
    async* http://localhost:8000/static/kagi/webauthn.js:312
    EventListener.handleEvent* http://localhost:8000/static/kagi/webauthn.js:309

Environment

  • macOS 10.14.6
  • Python 3.8.6
  • Django 3.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant