-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can node-midi become "Context Aware" ? #164
Comments
I have submitted a PR #213. @justinlatimer Can you please review, test, and publish at your earliest convenience? Thanks! |
@wookayin Ha:) Sorry, it seems like we made quite the same thing. Did you test your implementation? My first attempts with NAN_MODULE_WORKER_ENABLED was failed. Also, there is a necessity to support the previous version of node.js so you need to add conditional init of the module I guess. Anyway, here is my request #214 @justinlatimer now it's your turn :) |
Definitely need this one. I'd like to use the library in Electron. A bunch of other packages are also restricted on the basis that they use this one. |
Can this please be merged? Having the same problem as @Mister-SOSA :( EDIT: |
Any movement on this? Looks like the lib author @justinlatimer has been inactive on this repo for just about a year now, with his recent commits while he was active looking closer to maintenance than working on new features such as this |
I'd really like to contribute and help here. I also need to run
any idea? |
for those that are using this in electron, you should know that the web already has a midi API. https://developer.mozilla.org/en-US/docs/Web/API/Web_MIDI_API. |
I have opened a PR to do an overhaul of this library which includes solving this (#228) |
I intend to use node-midi in an Electron app. I bumped upon following Electron discussion :
electron/electron#18397
and I wonder what will happen when Electron 9 is released. Will node-midi require changes to make it context aware? If so are there plans to do so?
Thanks.
The text was updated successfully, but these errors were encountered: