Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn watch --filter=COMPONENT_NAME consistently fails during local development #777

Open
jamieomaguire opened this issue Sep 1, 2023 · 4 comments

Comments

@jamieomaguire
Copy link
Contributor

jamieomaguire commented Sep 1, 2023

On my Macbook Pro I often notice that saving file changes to any file within a component package currently being served by yarn watch results in an error (images attached).

I have encountered this error for pretty much all of our components, and it appears to happen regardless of whether or not the file had any errors in it at the time of saving.

Storybook changes never result in this issue, so I am fairly confident it is specifically related to packages and perhaps a dependency.

Has anyone else encountered this? It means roughly every 2-3 file changes I have to restart yarn watch.

Screenshot 2023-09-01 at 12 07 36 Screenshot 2023-09-01 at 12 11 31

Steps to reproduce:

It seems to happen whether or not you make an actual change to the file or just save the file with no changes.

  1. yarn
  2. yarn dev --filter=pie-storybook
  3. yarn watch --filter=pie-modal
  4. make a change to index.ts and save - nothing should break
  5. make another change to index.ts and save - nothing should break
  6. make a change to defs.ts (or just save the file again with no changes) - error should occur
@jamieomaguire jamieomaguire changed the title yarn watch --filter=COMPONENT_NAME consistently fails yarn watch --filter=COMPONENT_NAME consistently fails during local development Sep 1, 2023
@raoufswe
Copy link
Member

raoufswe commented Sep 1, 2023

I can confirm I've been facing the same issue for a while as well. will try to gather more details.

@xander-marjoram
Copy link
Contributor

xander-marjoram commented Sep 1, 2023

I've seen this issue before but I can't say I remember seeing it recently.

A couple of things we should probably try are making sure we're using the latest versions of Storybook and are providing all the requested peer dependencies, that should get us in a good place to investigate (or hopefully it resolves it!)

I've made #779, if you could try pulling that down and trying to reproduce that would be great!

@xander-marjoram
Copy link
Contributor

I managed to reproduce the issue on the branch for #779 so that won't solve it. There were lots of console errors so that's something to explore.

@xander-marjoram
Copy link
Contributor

@jamieomaguire Is this something you still notice happening? I don't usually use the watch command so can't say I've noticed it recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants