From d927560828fd590023b9b0e177ab883992e32119 Mon Sep 17 00:00:00 2001 From: jc_atertychnyi Date: Mon, 21 Oct 2024 12:20:10 +0300 Subject: [PATCH 1/2] Fix names and Dockerfile --- Dockerfile | 3 +-- Makefile | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Dockerfile b/Dockerfile index c75698f..8f81cd9 100644 --- a/Dockerfile +++ b/Dockerfile @@ -5,8 +5,7 @@ RUN mkdir /codebase RUN npm install -g plop tsx cross-env typescript COPY ./plop/* /plop - -CMD ['npm', 'run', 'plop'] +CMD ["bash", "-c", "npm run plop"] SHELL ["/bin/bash", "-c"] WORKDIR /plop diff --git a/Makefile b/Makefile index e6e1cac..ce34f0a 100644 --- a/Makefile +++ b/Makefile @@ -6,7 +6,7 @@ default: ## # CHANGELOG vars and targets ## -CONV_CHL_IMAGE := justcoded/php-conventional-changelog:latest +CONV_CHL_IMAGE := ghcr.io/justcoded/plopjs:latest CONV_CHL_DR := docker run -it --rm --volume "$$PWD":/codebase ${CONV_CHL_IMAGE} bash CONV_CHL_CMD := conventional-changelog --config changelog-config.php From 763e40f9ab958173547c3417ca2af8ca5ba632b5 Mon Sep 17 00:00:00 2001 From: jc_atertychnyi Date: Mon, 21 Oct 2024 12:42:47 +0300 Subject: [PATCH 2/2] Update Dockerfile, image path --- Dockerfile | 1 - Makefile | 2 +- README.md | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Dockerfile b/Dockerfile index 8f81cd9..d5a931d 100644 --- a/Dockerfile +++ b/Dockerfile @@ -6,7 +6,6 @@ RUN npm install -g plop tsx cross-env typescript COPY ./plop/* /plop CMD ["bash", "-c", "npm run plop"] -SHELL ["/bin/bash", "-c"] WORKDIR /plop diff --git a/Makefile b/Makefile index ce34f0a..e6e1cac 100644 --- a/Makefile +++ b/Makefile @@ -6,7 +6,7 @@ default: ## # CHANGELOG vars and targets ## -CONV_CHL_IMAGE := ghcr.io/justcoded/plopjs:latest +CONV_CHL_IMAGE := justcoded/php-conventional-changelog:latest CONV_CHL_DR := docker run -it --rm --volume "$$PWD":/codebase ${CONV_CHL_IMAGE} bash CONV_CHL_CMD := conventional-changelog --config changelog-config.php diff --git a/README.md b/README.md index ace2b48..bd324d4 100644 --- a/README.md +++ b/README.md @@ -17,5 +17,5 @@ This repository provides a Dockerized setup for [Plop.js](https://plopjs.com/), 1. **Run the Docker image**: You can use the local image name for now, or once finalized, use the public image URL provided by GitHub Actions: ```bash - docker run --rm -it plop_plop + docker run --rm -it ghcr.io/justcoded/plopjs:latest ```