From 9c92c708a73e039021bdd0945f0071de031ae196 Mon Sep 17 00:00:00 2001
From: shivaraj-bh <sbh69840@gmail.com>
Date: Wed, 5 Jun 2024 15:21:20 +0530
Subject: [PATCH] fix(postgres): stop init on error in `sql` scripts

From psql docs (https://www.postgresql.org/docs/current/app-psql.html):

> psql returns 0 to the shell if it finished normally, 1 if a fatal
error of its own occurs (e.g., out of memory, file not found), 2 if the
connection to the server went bad and the session was not interactive,
and 3 if an error occurred in a script and the variable ON_ERROR_STOP
was set.

Also resolves https://github.com/juspay/services-flake/issues/107
---
 nix/postgres/setup-script.nix | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/nix/postgres/setup-script.nix b/nix/postgres/setup-script.nix
index 69dccb7b..50e27531 100644
--- a/nix/postgres/setup-script.nix
+++ b/nix/postgres/setup-script.nix
@@ -1,12 +1,11 @@
 { config, pkgs, lib }:
 let
-  psqlUserArg = lib.optionalString (config.superuser != null) "-U ${config.superuser}";
   setupInitialSchema = dbName: schema: ''
     echo "Applying database schema on ${dbName}"
     if [ -f "${schema}" ]
     then
       echo "Running file ${schema}"
-      awk 'NF' "${schema}" | psql ${psqlUserArg} -d ${dbName}
+      awk 'NF' "${schema}" | psql_with_args -d ${dbName}
     elif [ -d "${schema}" ]
     then
       # Read sql files in version order. Apply one file
@@ -14,7 +13,7 @@ let
       # doesn't end in a ;.
       find "${schema}"/*.sql | while read -r f ; do
         echo "Applying sql file: $f"
-        awk 'NF' "$f" | psql ${psqlUserArg} -d ${dbName}
+        awk 'NF' "$f" | psql_with_args -d ${dbName}
       done
     else
       echo "ERROR: Could not determine how to apply schema with ${schema}"
@@ -29,13 +28,13 @@ let
           # Create initial databases
           dbAlreadyExists=$(
             echo "SELECT 1 as exists FROM pg_database WHERE datname = '${database.name}';" | \
-            psql ${psqlUserArg} -d postgres | \
+            psql_with_args -d postgres | \
             grep -c 'exists = "1"' || true
           )
           echo "$dbAlreadyExists"
           if [ 1 -ne "$dbAlreadyExists" ]; then
             echo "Creating database: ${database.name}"
-            echo 'create database "${database.name}";' | psql ${psqlUserArg} -d postgres
+            echo 'create database "${database.name}";' | psql_with_args -d postgres
             ${lib.optionalString (database.schemas != null)
               (lib.concatMapStrings (schema: setupInitialSchema (database.name) schema) database.schemas)}
           fi
@@ -43,13 +42,13 @@ let
         config.initialDatabases)
     else
       lib.optionalString config.createDatabase ''
-        echo "CREATE DATABASE ''${USER:-$(id -nu)};" | psql ${psqlUserArg} -d postgres '';
+        echo "CREATE DATABASE ''${USER:-$(id -nu)};" | psql_with_args -d postgres '';
 
 
   runInitialScript =
     let
       scriptCmd = sqlScript: ''
-        echo "${sqlScript}" | psql ${psqlUserArg} -d postgres
+        echo "${sqlScript}" | psql_with_args -d postgres
       '';
     in
     {
@@ -79,7 +78,11 @@ in
   name = "setup-postgres";
   runtimeInputs = with pkgs; [ config.package coreutils gnugrep gawk ];
   text = ''
-    set -euo pipefail
+    set -x
+    # Execute the `psql` command with default arguments
+    function psql_with_args() {
+      psql ${lib.optionalString (config.superuser != null) "-U ${config.superuser}"} -v "ON_ERROR_STOP=1" "$@"
+    }
     # Setup postgres ENVs
     export PGDATA="${config.dataDir}"
     export PGPORT="${toString config.port}"