Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] handle redirections for iframed content served by HyperSwitch #5593

Closed
2 tasks done
kashif-m opened this issue Aug 12, 2024 · 1 comment · Fixed by #5591 or #6494
Closed
2 tasks done

[FEATURE] handle redirections for iframed content served by HyperSwitch #5593

kashif-m opened this issue Aug 12, 2024 · 1 comment · Fixed by #5591 or #6494
Assignees
Labels
C-feature Category: Feature request or enhancement

Comments

@kashif-m
Copy link
Contributor

Feature Description

HyperSwitch's SDK / links is meant to work within top context at the client side. This behaviour changes when we introduce secure links - which are supposed to be iframed within merchant's top context. Any functionality which was consuming top context at the client side needs to be handled accordingly.

Possible Implementation

Major things which needs to be handled

  • client side redirections to happen at top context
    • client side redirections happen within current window context - which is assumed to be top (since the SDK integration requires this to be at top level)
    • when using iframed resources, SDK should handle redirection and make sure this happens in the top context
  • accessing protocol and hostname
    • this is also fetched from within the current window's context
    • needs to happen at top context

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

Yes, I am willing to submit a PR!

@kashif-m kashif-m added C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet labels Aug 12, 2024
@kashif-m kashif-m self-assigned this Aug 12, 2024
@kashif-m kashif-m linked a pull request Aug 12, 2024 that will close this issue
14 tasks
@SanchithHegde SanchithHegde removed the S-awaiting-triage Status: New issues that have not been assessed yet label Sep 22, 2024
@kashif-m
Copy link
Contributor Author

kashif-m commented Nov 6, 2024

Opening for juspay/hyperswitch-web#773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement
Projects
None yet
2 participants