-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] Update AnalyticsPool to hold variables for tenant ID #4521
Comments
@lsampras are all the analytic issues open for outside collaborators? |
All the issues are open for outside collaborators ideally (atleast for analytics), Once you ask to be assigned on an issue (could be a good-first-issue or not) the author can decide on it (there can be dependency on other issues or pending discussion or other conditions) @SanchithHegde correct me here in case we do have a specific label or convention... |
I would like to work on this. |
hey @lsampras can I get assigned for this issue. |
I'll assign this issue to @RaghavRox if he is still interested since we try to follow Sry for the confusion @subhajit20 you can pick this up if @RaghavRox is no longer interested or can take a look at one of the below issues |
Allright!! |
Update the AnalyticsProvider (or
AnalyticsConfig
) to hold a variable for tenant-ID.This can be achieved by simply adding a new field in the underlying structs for SqlxClient & ClickhouseClient.
Update the AnalyticsPool constructor method to accept a Tenant-ID.
Tenant-ID can be a new type field backed by a string;
pub struct TenantID(String);
For now the AnalyticsPool can be initialized with a fixed tenantID "default"
The text was updated successfully, but these errors were encountered: