From fd514d0b3db1fa685413449e15c726a5574b9623 Mon Sep 17 00:00:00 2001
From: Shankar Singh C <shankar.singh@juspay.in>
Date: Wed, 29 Nov 2023 12:14:44 +0530
Subject: [PATCH] add that metric to get locker sucessful response count

---
 .../router/src/core/payment_methods/cards.rs  | 46 ++++++++++++++++++-
 crates/router/src/routes/metrics.rs           |  1 +
 2 files changed, 45 insertions(+), 2 deletions(-)

diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index 258a279dac9d..7ff75f1ceb52 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -225,7 +225,13 @@ pub async fn add_card_to_locker(
             )
             .await
             .map_err(|error| {
-                metrics::CARD_LOCKER_FAILURES.add(&metrics::CONTEXT, 1, &[]);
+                metrics::CARD_LOCKER_FAILURES.add(
+                    &metrics::CONTEXT,
+                    1,
+                    &[router_env::opentelemetry::KeyValue::new(
+                        "locker", "basilisk",
+                    )],
+                );
                 error
             })
         },
@@ -250,7 +256,11 @@ pub async fn add_card_to_locker(
             )
             .await
             .map_err(|error| {
-                metrics::CARD_LOCKER_FAILURES.add(&metrics::CONTEXT, 1, &[]);
+                metrics::CARD_LOCKER_FAILURES.add(
+                    &metrics::CONTEXT,
+                    1,
+                    &[router_env::opentelemetry::KeyValue::new("locker", "rust")],
+                );
                 error
             })
         },
@@ -262,10 +272,26 @@ pub async fn add_card_to_locker(
     match add_card_to_rs_resp {
         value @ Ok(_) => {
             logger::debug!("card added to rust locker");
+            let _ = &metrics::CARD_LOCKER_SUCCESSFUL_RESPONSE.add(
+                &metrics::CONTEXT,
+                1,
+                &[
+                    router_env::opentelemetry::KeyValue::new("locker", "rust"),
+                    router_env::opentelemetry::KeyValue::new("operation", "add"),
+                ],
+            );
             value
         }
         Err(err) => {
             logger::debug!(error =? err,"failed to add card to rust locker");
+            let _ = &metrics::CARD_LOCKER_SUCCESSFUL_RESPONSE.add(
+                &metrics::CONTEXT,
+                1,
+                &[
+                    router_env::opentelemetry::KeyValue::new("locker", "basilisk"),
+                    router_env::opentelemetry::KeyValue::new("operation", "add"),
+                ],
+            );
             Ok(add_card_to_hs_resp)
         }
     }
@@ -337,10 +363,26 @@ pub async fn get_card_from_locker(
         .await
         .map(|inner_card| {
             logger::debug!("card retrieved from basilisk locker");
+            let _ = &metrics::CARD_LOCKER_SUCCESSFUL_RESPONSE.add(
+                &metrics::CONTEXT,
+                1,
+                &[
+                    router_env::opentelemetry::KeyValue::new("locker", "basilisk"),
+                    router_env::opentelemetry::KeyValue::new("operation", "get"),
+                ],
+            );
             inner_card
         }),
         Ok(_) => {
             logger::debug!("card retrieved from rust locker");
+            let _ = &metrics::CARD_LOCKER_SUCCESSFUL_RESPONSE.add(
+                &metrics::CONTEXT,
+                1,
+                &[
+                    router_env::opentelemetry::KeyValue::new("locker", "rust"),
+                    router_env::opentelemetry::KeyValue::new("operation", "add"),
+                ],
+            );
             get_card_from_rs_locker_resp
         }
     }
diff --git a/crates/router/src/routes/metrics.rs b/crates/router/src/routes/metrics.rs
index a8e6f9d2a892..192df1a09298 100644
--- a/crates/router/src/routes/metrics.rs
+++ b/crates/router/src/routes/metrics.rs
@@ -85,6 +85,7 @@ counter_metric!(CONNECTOR_HTTP_STATUS_CODE_5XX_COUNT, GLOBAL_METER);
 
 // Service Level
 counter_metric!(CARD_LOCKER_FAILURES, GLOBAL_METER);
+counter_metric!(CARD_LOCKER_SUCCESSFUL_RESPONSE, GLOBAL_METER);
 counter_metric!(TEMP_LOCKER_FAILURES, GLOBAL_METER);
 histogram_metric!(CARD_ADD_TIME, GLOBAL_METER);
 histogram_metric!(CARD_GET_TIME, GLOBAL_METER);