From 1a66e0f1e620a2f2a1e6e8c7f7a6ef91e73a2179 Mon Sep 17 00:00:00 2001 From: Sahkal Poddar Date: Thu, 12 Oct 2023 13:15:43 +0530 Subject: [PATCH] refactor(router): addressed pr comments --- config/config.example.toml | 4 ++++ crates/api_models/src/payments.rs | 8 ++++---- crates/router/src/core/payment_link/payment_link.html | 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/config/config.example.toml b/config/config.example.toml index bee61f2f6156..e97b73d87c6b 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -431,3 +431,7 @@ apple_pay_ppc = "APPLE_PAY_PAYMENT_PROCESSING_CERTIFICATE" #Payment apple_pay_ppc_key = "APPLE_PAY_PAYMENT_PROCESSING_CERTIFICATE_KEY" #Private key generate by Elliptic-curve prime256v1 curve apple_pay_merchant_cert = "APPLE_PAY_MERCHNAT_CERTIFICATE" #Merchant Certificate provided by Apple Pay (https://developer.apple.com/) Certificates, Identifiers & Profiles > Apple Pay Merchant Identity Certificate apple_pay_merchant_cert_key = "APPLE_PAY_MERCHNAT_CERTIFICATE_KEY" #Private key generate by RSA:2048 algorithm + + +[payment_link] +sdk_url = "http://localhost:9090/dist/HyperLoader.js" \ No newline at end of file diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 96616aeff82e..fc1d85d99ea2 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -2915,18 +2915,18 @@ pub struct PaymentLinkObject { pub merchant_custom_domain_name: Option, } -#[derive(Default, Debug, serde::Deserialize, serde::Serialize, Clone, ToSchema)] +#[derive(Default, Debug, serde::Deserialize, Clone, ToSchema)] pub struct RetrievePaymentLinkRequest { pub client_secret: Option, } -#[derive(Clone, Debug, serde::Serialize, PartialEq, serde::Deserialize, ToSchema)] +#[derive(Clone, Debug, serde::Serialize, PartialEq, ToSchema)] pub struct PaymentLinkResponse { pub link: String, pub payment_link_id: String, } -#[derive(Clone, Debug, serde::Serialize, serde::Deserialize, ToSchema)] +#[derive(Clone, Debug, serde::Serialize, ToSchema)] pub struct RetrievePaymentLinkResponse { pub payment_link_id: String, pub payment_id: String, @@ -2943,7 +2943,7 @@ pub struct RetrievePaymentLinkResponse { pub link_expiry: Option, } -#[derive(Clone, Debug, serde::Serialize, serde::Deserialize, ToSchema)] +#[derive(Clone, Debug, serde::Deserialize, ToSchema)] pub struct PaymentLinkInitiateRequest { pub merchant_id: String, pub payment_id: String, diff --git a/crates/router/src/core/payment_link/payment_link.html b/crates/router/src/core/payment_link/payment_link.html index 3dadddda5bae..4ce2ff1919be 100644 --- a/crates/router/src/core/payment_link/payment_link.html +++ b/crates/router/src/core/payment_link/payment_link.html @@ -4,7 +4,7 @@ {{ hyperloader_sdk_link }}