fix: card input error text correction #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritro2002
requested review from
seekshiva,
PritishBudhiraja and
ArushKapoorJuspay
as code owners
|
Review changes with |
PritishBudhiraja
added
the
Ready for Review
aritro2002
force-pushed
the
fix/card-number-input
branch
from
d243100 to
9295c7a
Compare
|
I have added locale support for 'Please enter a valid card number' validation message using google translate. |
PritishBudhiraja
temporarily deployed
to
Testing
GitHub Actions
Inactive
PritishBudhiraja
approved these changes
Nov 4, 2024
PritishBudhiraja
temporarily deployed
to
Testing
GitHub Actions
Inactive
PritishBudhiraja
temporarily deployed
to
Testing
GitHub Actions
Inactive
github-actions
bot
added
Closed
PritishBudhiraja
pushed a commit
that referenced
this pull request
Nov 4, 2024
## [0.99.1](v0.99.0...v0.99.1) (2024-11-04) ### Bug Fixes * card input error text correction ([#759](#759)) ([f426662](f426662))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The error message for an incorrect card number is not displaying accurately. Additionally, the error message does not disappear when the input field is focused.
Before:
Screen.Recording.2024-10-30.at.4.15.24.PM.mov
After:
Screen.Recording.2024-10-30.at.4.16.06.PM.mov
How did you test it?
Tested via rendering the SDK in firefox ,safari and chrome
Checklist
npm run re:build