Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Customisable Search Window using SkinShortcuts #88

Open
Nuklear92 opened this issue Oct 6, 2021 · 3 comments
Open

[Request] Customisable Search Window using SkinShortcuts #88

Nuklear92 opened this issue Oct 6, 2021 · 3 comments

Comments

@Nuklear92
Copy link

Nuklear92 commented Oct 6, 2021

As the title says, using the latest v4.1.3 Homescreen or Main Menu "Search" aka Skin.SetString(SearchTerm) isn't performing any searches whenever I type anything being an addon, movie, show, program, etc. I even tried deleting it within the Customize Main Menu option and when I tried using the Restore Menu Items it's not showing anymore as an original menu item that can be restore if accidentally deleted. It's just gone, also there's not a single option within Skin Settings to actually bring it back, customize what can it search, etc. similar to Arctic Horizon skin.

I don't have any logs for this as it never prompted me any errors or anything it simply didn't work and when I delete it I can't bring it back either as I mentioned above.

I don't know if this was intentionally deleted by you or perhaps something within the skin code broke it, etc. Hopefully, this is something you can bring back and perhaps if there's a possibility to add some customization for it similar to A.H that you can even make it Search movies and shows from TMDB Helper Addon.

Platform: Nvidia Shield Pro 2019
Kodi Version: 19.1
Skin Version: Eminence v2 4.1.3

@jurialmunkey
Copy link
Owner

jurialmunkey commented Oct 7, 2021

Eminence never implemented that method. That was a Skin trick using a custom window that I introduced in Arctic Zephyr 2 and is specific to that skin (and so also appears in Arctic Horizon since it's based on AZ2). It doesn't appear in any of my other skins and definitely not Eminence since it was made way before AZ2.

@jurialmunkey
Copy link
Owner

If you want a global search you'll need to use the global search addon for the time being.

I'll probably implement a custom search window using skinshortcuts similar to AZ2 eventually but it was never a feature in Eminence, so it isn't a case of being a feature disabled/removed that can just be turned back on

@Nuklear92
Copy link
Author

Oh, I understand now. Thanks for the information, hopefully you can eventually indeed add that similar trick that AZ and AH has to have a search option/button in the homescreen. 👍

@jurialmunkey jurialmunkey changed the title [BUG] Home Screen “Search” not performing searches [Request] Customisable SkinShortcuts based Search window Oct 10, 2021
@jurialmunkey jurialmunkey changed the title [Request] Customisable SkinShortcuts based Search window [Request] Customisable Search Window using SkinShortcuts Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants