Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter to allow using Voici! #5

Open
martinRenou opened this issue May 17, 2023 · 8 comments
Open

Add a parameter to allow using Voici! #5

martinRenou opened this issue May 17, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@martinRenou
Copy link
Member

Problem

It would be great to have an option to use the Voici jupyterlite addon https://github.com/voila-dashboards/voici so that people could generate dashboards easily!

@martinRenou martinRenou added the enhancement New feature or request label May 17, 2023
@jtpio
Copy link
Member

jtpio commented May 17, 2023

Maybe Voici could still be used with the jupyter lite build command via the addon configuration?

@martinRenou
Copy link
Member Author

Yes it can! It's a regular addon.

@yuvipanda
Copy link
Collaborator

Perfect! So we just need to document that the builder will look for this config file?

@yuvipanda
Copy link
Collaborator

I don't see from https://github.com/voila-dashboards/voici how to enable this with a jupyter_lite_config file. Is there an example?

@martinRenou
Copy link
Member Author

You just need Voici to be installed with pip and the Voici addon should load automatically. Then you can configure jupyterlite to build only Voici with the apps option being set to just ["voici"]

@yuvipanda
Copy link
Collaborator

Ah, I see. Should we just add that by default to all builds? Or detect that it is wanted somehow?

@martinRenou
Copy link
Member Author

It may be nice to be able to define build dependencies like Voici or jupyterlite-xeus-lua (or any other jupyterlite kernel) that would be installed by repo2jupyterlite automatically prior to building the lite output. Do you think that would be feasible? Otherwise installing voici by default may be the way to go.

@yuvipanda
Copy link
Collaborator

@martinRenou so I want to 'preserve' the meaning of environment.yml (and in the future, requirements.txt) to only count for things that are installed at runtime. Perhaps what we can do instead is to look for something that enables this in jupyter-lite.json or similar, and use that to install in the build env? I don't want to ship features to things that don't opt in for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants