-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option "Using a custom Pyodide distribution" (specified in jupyter-lite.json
) not working
#59
Comments
Hey, @jtpio - sorry for the quick ping. I would greatly appreciate it if you could have a quick look. Is this something that needs to be fixed in either the pyodide-kernel or jupyterlite? I added a package to pyodide back in June, which was only now included in the 0.24.0 release - I'd very much like to demo that at our conference next week. If would be very helpful for me to find out if I will be able to use the latest version of pyodide within a JupyterLite environment by then. |
@michaelweinold normally the config option as specified in the top comment should do the trick. But we could also update the Pyodide version in this repo and make a new release. Would you like to open a PR? The diff would be similar to #50. Thanks! |
...ok, since the config option seems to be correct as-is, I opened the PR you suggested: #61 |
Maybe there is still an issue with the config option that would have to be fixed anyway (would need to check). |
There are more than a few breaking changes in the new release. The first one is the renaming of |
|
It would seem so, @jtpio - I tried again with: {
"jupyter-lite-schema-version": 0,
"jupyter-config-data": {
"settingsStorageDrivers": ["asyncStorage"],
"contentsStorageDrivers": ["asyncStorage"],
"litePluginSettings": {
"@jupyterlite/pyodide-kernel-extension:kernel": {
"pyodideUrl": "https://cdn.jsdelivr.net/pyodide/v0.26.2/full/pyodide.js"
},
},
},
} But I still get: The GH Actions build log also does not tell me which version was ultimately used. |
@michaelweinold could it be because this JSON snippet contains trailing commas ? I just tried in a clean folder with {
"jupyter-lite-schema-version": 0,
"jupyter-config-data": {
"settingsStorageDrivers": ["asyncStorage"],
"contentsStorageDrivers": ["asyncStorage"],
"litePluginSettings": {
"@jupyterlite/pyodide-kernel-extension:kernel": {
"pyodideUrl": "https://cdn.jsdelivr.net/pyodide/v0.26.2/full/pyodide.js"
}
}
}
} |
If that's the case and it fixes your issue, maybe the |
Thanks @michaelweinold for checking 👍 I opened jupyterlite/jupyterlite#1447 to improve this in the |
Description
Even though I specify the most recent version of
pyodide==0.24.0
in thejupyter-lite.json
file, as per the JupyterLite Documentation: "Using a custom Pyodide distribution":and the site build from the GH actions workflow
completes successfully, the
pyodide
version does not change from the default0.23.4
shipped withjupyterlite-pyodide-kernel==0.1.1
:Is there another way to specify the exact version of Pyodide during the build?
Reproduce
Specify pyodide=0.24.0 in the
.json
config file in a fork of the JupyterLite demo.Expected behavior
The most recent version of
pyodide
is used.Context
jupyterlite-core==0.1.2
Browser Output
The text was updated successfully, but these errors were encountered: